Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: add opbnb networks' genesis #60

Conversation

redhdx
Copy link
Contributor

@redhdx redhdx commented Feb 4, 2024

Description

Users can now start nodes on opBNB mainnet or testnet without relying on geth init genesis.json.

Rationale

For builtin networks, running without geth init is convenient.
There are two builtin networks opbnb mainnet and testnet.

Example

You can start opbnb mainnet or testnet without init genesis.json by add command --opBNBMainnet or --opBNBTestnet in the first time to start new node.
If you have already inited genesis.json, you can still use these two command lines, which will check whether the content of your init is correct.
Please ignore opBNBQANet, it is for internal testing only.

Changes

Notable changes:

  • Include the opbnb mainnet and testnet genesis block data.
  • Add --opBNBMainnet and --opBNBTestnet command lines.
  • Add start description log which opbnb network to use.
  • Rename opBNBDevnet to opBNBQANet.

@redhdx redhdx requested a review from bnoieh February 4, 2024 06:18
cmd/utils/flags.go Outdated Show resolved Hide resolved
Copy link
Contributor

@welkin22 welkin22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bnoieh bnoieh merged commit 59977b6 into bnb-chain:merge-upstream-v1.101304.1 Feb 23, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants