feat(op-batcher/op-proposer): add InstrumentedClient #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andyzhang2023
approved these changes
Jan 8, 2024
nolanxyg
approved these changes
Jan 8, 2024
bnoieh
approved these changes
Jan 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently neither op-batcher nor op-proposer has metrics related to RPC clients, so we cannot know the performance of requesting L1 and L2 endpoints. We need to solve this problem.
Rationale
We add InstrumentedClient in op-service, which is responsible for collecting metrics for each method.
Example
Example of new metrics:
op_batcher_default_rpc_client_requests_total
op_proposer_default_rpc_client_requests_total
op_batcher_default_rpc_client_request_duration_seconds_bucket
op_proposer_default_rpc_client_request_duration_seconds_bucket
Changes
Notable changes: