Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(op-node): remove 3s stepCtx for sequencer #111

Merged
merged 2 commits into from
Jan 11, 2024

Conversation

bnoieh
Copy link
Contributor

@bnoieh bnoieh commented Jan 11, 2024

Description

remove 3s timeout context for sequencer in case stepReqCh

Rationale

for 200M block gas limit, full block could has 9k+ txns and call eth_getBlockByHash to get a fullblock would timeout if we limited timeout context to 3s, which especially would happen when resetting pipeline

Example

n/a

Changes

remove 3s timeout context for sequencer in case stepReqCh in state.go

@github-actions github-actions bot requested review from redhdx and welkin22 January 11, 2024 10:01
Copy link
Contributor

@welkin22 welkin22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@owen-reorg owen-reorg merged commit 71b17cc into bnb-chain:develop Jan 11, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants