-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fix CI after 4844 merge #198
Merged
owen-reorg
merged 13 commits into
bnb-chain:develop
from
welkin22:fix_ci_after_4844_merge
May 20, 2024
Merged
fix: fix CI after 4844 merge #198
owen-reorg
merged 13 commits into
bnb-chain:develop
from
welkin22:fix_ci_after_4844_merge
May 20, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bnoieh
approved these changes
May 16, 2024
owen-reorg
reviewed
May 17, 2024
owen-reorg
reviewed
May 17, 2024
owen-reorg
reviewed
May 17, 2024
owen-reorg
approved these changes
May 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
After merging the code from upstream v1.7.2, our CI pipeline failed to pass. This is due to differences in the code on both sides. I modified the test code to make the CI pipeline pass again.
In addition, there are three points worth noting:
Rationale
Modify the code to make the CI pipeline pass.
Example
none
Changes
Notable changes: