Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(op-node): support multi clients to fetch blobs #199

Merged
merged 19 commits into from
May 30, 2024

Conversation

bnoieh
Copy link
Contributor

@bnoieh bnoieh commented May 14, 2024

Description

  1. add new feature to support multi archive clients to fetch blobs
  • users can set --l1.archive-blob-rpc=archive_url_1,archive_url_2 to fallback to archive blob node when fetching blobs which non-archive blob nodes don't have
  • it's optional flag, if not set, op-node will create blob client from flag --l1; if set, op-node will create blob clients both from --l1 and --l1.archive-blob-rpc, and will rotate all endpoints whenever a client runs into an error or return nil(skip non-archive node) while fetching blobs.
  1. add ci for op-service, which is missed in current code

Rationale

to support fallback to archive blob node when fetching blobs which non-archive blob nodes don't have

Example

n/a

Changes

  1. add new BSCBlobClient, which including a client pool to fetching blobs.
  2. remove blob fetching related methods from L1Client
  3. add related new optional flags l1.archive-blob-rpc, l1.blob-rpc-rate-limit, l1.blob-rpc-max-batch-size
  4. add ci for op-service

@github-actions github-actions bot requested review from andyzhang2023 and redhdx May 14, 2024 11:38
@bnoieh bnoieh requested a review from welkin22 May 15, 2024 02:27
op-node/node/node.go Outdated Show resolved Hide resolved
op-node/node/client.go Outdated Show resolved Hide resolved
andyzhang2023
andyzhang2023 previously approved these changes May 17, 2024
Copy link

@andyzhang2023 andyzhang2023 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

op-service/sources/blob_client.go Outdated Show resolved Hide resolved
op-node/flags/flags.go Outdated Show resolved Hide resolved
owen-reorg
owen-reorg previously approved these changes May 29, 2024
Copy link
Contributor

@welkin22 welkin22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@andyzhang2023 andyzhang2023 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@owen-reorg owen-reorg merged commit 00d3473 into bnb-chain:develop May 30, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants