feat: fastnode support by trigger el-sync when needed #201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
redhdx
reviewed
May 27, 2024
redhdx
reviewed
May 27, 2024
owen-reorg
reviewed
May 27, 2024
krish-nr
force-pushed
the
fastnode_support
branch
from
4fb86ec to
b1c179e
Compare
krish-nr
force-pushed
the
fastnode_support
branch
from
b1c179e to
93a8ab3
Compare
owen-reorg
approved these changes
Jun 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In the current synchronization mode, fastnode-type nodes fail to synchronize when a gap needs to be filled because elsync is not enabled by default. We have added a mechanism to trigger elsync in such scenarios.
Rationale
Added two configurations:
--fastnode=true(default is false)--el-trigger.gap=86400(default value)These two configurations are not dependent on each other.
When fastnode is set to true, elsync will be automatically triggered every time fastnode starts.
In certain scenarios, where the block height is significantly lagging, we still want to enable elsync. In such cases, we can set
el-trigger.gapto specify the lagging block height that triggers elsync. This configuration only takes effect when--syncmode=execution-layeris set.Example
N/A
Changes
Notable changes: