Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(devnet): fork offset should be 0x #210

Merged
merged 1 commit into from
Jun 14, 2024

Conversation

welkin22
Copy link
Contributor

Description

After the last merge of upstream code, our Devnet's batcher defaults to submitting blob spanbatch data, but the Delta and Ecotone hard fork configurations were not enabled in the genesis block, causing issues after devnet starts, with the safe block height not increasing. We need to fix this issue.

Rationale

Enable Delta and Ecotone forks in the Devnet's genesis block so that batchers can submit data of type blob spanbatch.

Example

none

Changes

Notable changes:

  • set l2GenesisDeltaTimeOffset and L2GenesisEcotoneTimeOffset to 0x0

@github-actions github-actions bot requested review from owen-reorg and redhdx June 12, 2024 10:16
Copy link
Contributor

@redhdx redhdx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@owen-reorg owen-reorg merged commit 92cada6 into bnb-chain:develop Jun 14, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants