-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(op-node) Keep consistent status when meet an unexpected el sync #222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krish-nr
force-pushed
the
pbss_recover_chore
branch
from
July 31, 2024 02:08
5e7ce6c
to
0de1dc7
Compare
krish-nr
force-pushed
the
pbss_recover_chore
branch
from
August 1, 2024 02:03
0de1dc7
to
b9a212b
Compare
welkin22
reviewed
Aug 2, 2024
welkin22
reviewed
Aug 2, 2024
krish-nr
force-pushed
the
pbss_recover_chore
branch
from
August 6, 2024 00:26
5419a13
to
87b9c90
Compare
welkin22
reviewed
Aug 6, 2024
welkin22
reviewed
Aug 6, 2024
welkin22
reviewed
Aug 6, 2024
krish-nr
force-pushed
the
pbss_recover_chore
branch
from
August 6, 2024 09:51
379dccb
to
ed8c9e8
Compare
krish-nr
force-pushed
the
pbss_recover_chore
branch
from
August 6, 2024 09:59
ed8c9e8
to
5ed6112
Compare
welkin22
approved these changes
Aug 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
andyzhang2023
approved these changes
Aug 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When op-geth meet an unexpected shutdown(OOM, forcekill, etc...) and the truncate operation results in the deletion of head data, the block-by-block insertion requests from op-node will trigger an EL sync in geth. This PR addresses this situation.
related geth change: https://github.com/bnb-chain/op-geth/pull/132
Rationale
When handling unexpected EL sync triggers, state synchronization is performed based on the specific errors returned by geth.
Example
N/A
Changes