Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): support building arm64 architecture #239

Merged
merged 9 commits into from
Sep 10, 2024

Conversation

welkin22
Copy link
Contributor

@welkin22 welkin22 commented Sep 5, 2024

Description

We need to support arm64 architecture Docker images

Rationale

Due to the introduction of dependencies from github.com/bnb-chain/greenfield-cometbft, modules like op-node require CGO to be enabled during the build process. When cross-compiling, CGO is disabled by default, so we need to explicitly enable it with CGO_ENABLED=1. We also need to download the aarch64-linux-musl-gcc cross-compiler and enable it using the parameter CC=aarch64-linux-musl-gcc.
Use provenance: false to resolve the display of unknown/unknown type image names.

Example

none

Changes

Notable changes:

  • docker-release.yml
  • Makefile Dockerfile

@github-actions github-actions bot requested review from bnoieh and redhdx September 5, 2024 12:54
@welkin22 welkin22 changed the base branch from main to develop September 6, 2024 02:13
@owen-reorg owen-reorg merged commit b924d7b into bnb-chain:develop Sep 10, 2024
4 checks passed
@owen-reorg owen-reorg mentioned this pull request Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants