-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support AWS key manager #72
Merged
Merged
+144
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t/key_manager_debug
welkin22
requested changes
Oct 23, 2023
owen-reorg
reviewed
Oct 24, 2023
owen-reorg
reviewed
Oct 24, 2023
Co-authored-by: bendanzhentan <136774549+bendanzhentan@users.noreply.github.com>
bendanzhentan
approved these changes
Oct 27, 2023
owen-reorg
approved these changes
Nov 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Provides keys for service management op-node, op-batcher, and op-proposer using the AWS platform
Rationale
The current key management is written in the configuration file, which is easy to be stolen. In the service management key of the AWS platform, only pods with permissions can obtain the corresponding key.
Example
Add configuration of environment variables
Changes
Add op_aws_sdk module to load keys stored in aws platform
Op-node, op-batcher, op-proposer add methods to obtain keys