-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(op-node): add opBNB bootnodes #89
Merged
owen-reorg
merged 4 commits into
bnb-chain:develop
from
redhdx:feature/add_op_node_bootnodes
Dec 12, 2023
Merged
feat(op-node): add opBNB bootnodes #89
owen-reorg
merged 4 commits into
bnb-chain:develop
from
redhdx:feature/add_op_node_bootnodes
Dec 12, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
owen-reorg
reviewed
Nov 20, 2023
welkin22
reviewed
Nov 20, 2023
Co-authored-by: welkin22 <136572398+welkin22@users.noreply.github.com>
welkin22
approved these changes
Nov 22, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
krish-nr
approved these changes
Nov 27, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/LGTM
This PR is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 5 days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add
opBNB
testnet and mainnet bootnodes in code.Rationale
Add
opBNB
testnet and mainnet bootnodes in code can facilitate the startup of new nodes.Example
The startup node will use the
opBNB
bootnodes by chainId including testnet and mainnet. Ifp2p.bootnodes
is configured, the configured bootnodes will be used. The configuredp2p.bootnodes
have the highest priority.Changes
Add
opBNB
testnet and mainnet bootnodes in code.