fix: spec mapping issue and snapshot overwrite issue #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
forcodedancing
approved these changes
Jul 1, 2024
unclezoro
reviewed
Jul 1, 2024
| @@ -112,12 +112,16 @@ pub fn revm_spec(chain_spec: &ChainSpec, block: Head) -> revm_primitives::SpecId | |||
| } else if chain_spec.fork(Hardfork::Gibbs).active_at_head(&block) { | |||
| // bsc mainnet and testnet have different order for Moran, Nano and Gibbs | |||
There was a problem hiding this comment.
For BSC mainnet, if chain_spec.fork(Hardfork::Gibbs).active_at_head(&block), it should return Gibbs, isn't it?
However it is no way to return Gibbs now.
unclezoro
reviewed
Jul 1, 2024
| @@ -112,12 +112,16 @@ pub fn revm_spec(chain_spec: &ChainSpec, block: Head) -> revm_primitives::SpecId | |||
| } else if chain_spec.fork(Hardfork::Gibbs).active_at_head(&block) { | |||
| // bsc mainnet and testnet have different order for Moran, Nano and Gibbs | |||
| return if chain_spec.fork(Hardfork::Moran).active_at_head(&block) { | |||
| revm_primitives::GIBBS | |||
| revm_primitives::MORAN | |||
| } else if chain_spec.fork(Hardfork::Nano).active_at_head(&block) { | |||
| revm_primitives::NANO | |||
| } else { | |||
| revm_primitives::EULER | |||
unclezoro
approved these changes
Jul 2, 2024
pythonberg1997
added a commit
to pythonberg1997/reth
that referenced
this pull request
Jul 3, 2024
* ci: tag non-beta version as latest image (bnb-chain#51) * chore: add bsc and docker commands to readme (bnb-chain#50) * chore: add bsc commands to readme * fix review comments * fix op dockerfile issue * fix: spec mapping issue and snapshot overwrite issue (bnb-chain#52) * fix: system account status issue (bnb-chain#53) * test1 * test2 * test3 * test4 * test5 * test6 * test7 * test8 * update CI --------- Co-authored-by: dylanhuang <j75689@gmail.com> Co-authored-by: forcodedancing <just.haha.it@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pr is to fix some sync issues of bsc
Rationale
tell us why we need these changes...
Example
add an example CLI or API response...
Changes
Notable changes:
Potential Impacts