Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cherry pick > curve as parameter (#137) #139

Merged
merged 2 commits into from
Sep 9, 2021
Merged

cherry pick > curve as parameter (#137) #139

merged 2 commits into from
Sep 9, 2021

Conversation

FitzLu
Copy link
Contributor

@FitzLu FitzLu commented Aug 13, 2021

  • move curve into tss.Parameters

  • regen proto with full package name

  • pass curve through parameter

  • add curve name in ecpoint json serialization

FitzLu and others added 2 commits August 13, 2021 16:32
@FitzLu
cherry pick > curve as parameter (#137)
1aa0a75 
* move curve into tss.Parameters

* regen proto with full package name

* pass curve through parameter

* add curve name in ecpoint json serialization
gofmt
1cfbd1c
@ackratos ackratos requested a review from yycen September 2, 2021 06:04
@FitzLu FitzLu marked this pull request as ready for review September 2, 2021 06:05
@yycen
Copy link
Contributor

yycen commented Sep 3, 2021

Everything seems good. Also do you think it's better to write round.EC() instead of round.Params().EC() for it is a promoted field?

@yycen yycen mentioned this pull request Sep 3, 2021
Closed
@yycen yycen merged commit 15e17db into master Sep 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yycen yycen yycen approved these changes

@ackratos ackratos ackratos approved these changes

@w20089527 w20089527 Awaiting requested review from w20089527

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@FitzLu @yycen @ackratos