Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Latest commit date to the table #304

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

balazsorban44
Copy link

Add Latest commit date to the table.

Add Latest commit date to the table.
@bnb
Copy link
Owner

bnb commented Jan 30, 2018

I really like this, but the load time is pretty huge - effectively doubling our current load time. Do you know if there's any way to reduce this? 🤔

@bnb
Copy link
Owner

bnb commented Jan 30, 2018

It also looks like there's so many requests that the last few start timing out:
image

@balazsorban44
Copy link
Author

balazsorban44 commented Jan 30, 2018

I see. To be honest with you, I would rather have the information about "up-to-dateness", then downloads... Should I delete the Downloads column or you think it is more important?

Or maybe the README.md could be split into different files. Each with one category, maybe.

@bnb
Copy link
Owner

bnb commented Jan 31, 2018

I honestly agree with you in terms of up-to-dateness. That said, I've been much less involved/invested in this than some of the other maintainers as of late and they have much more investment than I do - I wouldn't want to override their opinions before hearing them.

@darahak @chabou @matheuss could you share your thoughts?

@chabou
Copy link
Collaborator

chabou commented Feb 3, 2018

Last commit date is not relevant imo. Plugins are attended to be as small as possible and shouldn't be updated every week.

A simple example: https://github.com/chabou/hyper-always-on-top no commit since 11 months. But, you know, it just works.

@darahak
Copy link
Collaborator

darahak commented Feb 3, 2018

I agree with @chabou: downloads can give an idea about a package's popularity, but last commit date alone doesn't mean much.

For reference, I like how npms is rating quality and maintenance.
It would be cool if we could make badges with those scores.

@balazsorban44
Copy link
Author

balazsorban44 commented Feb 3, 2018

They have an API, so it would be possible.
Here is some scores for hyper-always-on-top:

https://api.npms.io/v2/package/hyper-always-on-top
https://api.npms.io/v2/package/hyper-always-on-top
https://api.npms.io/v2/package/hyper-always-on-top

https://api.npms.io/v2/package/hyper-always-on-top

Though I don't know how to turn it into a percentage or even cut the digits so it would be shorter. Or which one of these values give the most accurate result.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants