Skip to content

Commit

Permalink
Merge pull request #5258 from pkriens/master
Browse files Browse the repository at this point in the history
[export] JPMS module info calculation fails
  • Loading branch information
pkriens authored May 23, 2022
2 parents 7947fde + 92ede60 commit ebe59ed
Showing 1 changed file with 18 additions and 13 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -357,19 +357,24 @@ public Jar executable() throws Exception {
}
}

List<String> bcpList = new ArrayList<>();
bcpList.add(".");
bcpList.addAll(classpath);
bcpList.addAll(actualPaths);

builder.setProperty(BUNDLE_CLASSPATH, bcpList.stream()
.collect(joining(",")));
builder.setProperty(EXPORT_CONTENTS, "aQute.launcher.pre");

// Ignore common warnings resulting from the Bundle-ClassPath which
// are irrelevant in this use case
builder.setProperty(FIXUPMESSAGES,
"Classes found in the wrong directory, private references, Export-Package duplicate package name, Invalid package name: * in Export-Package");
String moduleProperty = builder.getProperty(JPMS_MODULE_INFO);
if (moduleProperty != null) {

List<String> bcpList = new ArrayList<>();
bcpList.add(".");
bcpList.addAll(classpath);
bcpList.addAll(actualPaths);

builder.setProperty(BUNDLE_CLASSPATH, bcpList.stream()
.collect(joining(",")));
builder.setProperty(EXPORT_CONTENTS, "aQute.launcher.pre");

// Ignore common warnings resulting from the Bundle-ClassPath
// which
// are irrelevant in this use case
builder.setProperty(FIXUPMESSAGES,
"Classes found in the wrong directory, private references, Export-Package duplicate package name, Invalid package name: * in Export-Package");
}

LauncherConstants lc = getConstants(actualPaths, true);
lc.embedded = true;
Expand Down

0 comments on commit ebe59ed

Please sign in to comment.