-
-
Notifications
You must be signed in to change notification settings - Fork 304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[bndtools] Need -include loop detection #5336
Milestone
Comments
kriegfrj
changed the title
[m2e] StackOverflow, NPE logged in bndtools
[bndtools] Need -include loop detection
Aug 10, 2022
I just figured out the problem: I thought I had modified It would be good to have some loop detection in the |
pkriens
added a commit
to pkriens/bnd
that referenced
this issue
Oct 6, 2022
The problem was that there was no test cases. There actually was a loop detection. I already was incredibly surprised because I am pretty sure I wrote this code and forgetting to check cycles is even beneath me.However, I'd forgotten to add a return after the error message ... So the code continued forever to include the same file anyway although dutifully reporting it. Fixes bndtools#5336 Signed-off-by: Peter Kriens <Peter.Kriens@aqute.biz>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In 6.4.0.202206161450-SNAPSHOT of Bndtools:
I got a StackOverflowError:
Not exactly sure how it happened, but it was after I had manipulated a
.bndrun
file. I had:base.bndrun
server.bndrun
includesbase.bndrun
.server-dev.bndrun
started off life as a clone ofserver.bndrun
(and hence also included base.bndrun). The last change I made before the stack overflow was to changeserver-dev
's include statement to includeserver.bndrun
instead ofbase.bndrun
.Eclipse recommended that I restart the Workbench, which I did. The StackOverflow happened again on restart. Instead of answering "Yes" to the "do you want to exit" question, I closed the bndrun editor. Seems to be stable now.
Possibly related: found this in the error log afterward:
I suspect the above NPE occured because of the StackOverflow, the workspace object failed to initialise properly, eg per this log message:
The text was updated successfully, but these errors were encountered: