gradle: bundle task type did not handle plain files in configuration #1490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: BJ Hargrave <bj@bjhargrave.com>
With a configuration set up using files:
dependencies {
compile files('lib/foo.jar')
}
The jar is not in the resolvedConfiguration. See we now use the getFiles
method on Configuration and then probe each file to make sure it is a
zip file before sending adding to the builder class path.
Closes #1484
Signed-off-by: BJ Hargrave <bj@bjhargrave.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With a configuration set up using files:
The jar is not in the resolvedConfiguration. So we now use the
getFiles()method on Configuration and then probe each file to make sure it is a
zip file before adding to the builder class path.
Closes #1484