Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gradle: Use dependency's jars for compilation #3642

Merged
merged 2 commits into from
Dec 9, 2019
Merged

gradle: Use dependency's jars for compilation #3642

merged 2 commits into from
Dec 9, 2019

Commits on Dec 9, 2019

  1. gradle: Replace use of deprecated ExternalDependency.setForce method 

    We now use the newer strictly DSL.

See https://docs.gradle.org/6.0.1/userguide/rich_versions.html

Signed-off-by: BJ Hargrave <bj@bjhargrave.com>
    @bjhargrave
    bjhargrave committed Dec 9, 2019
    Configuration menu
    Copy the full SHA
    1712adb View commit details
    Browse the repository at this point in the history

  2. gradle: Use dependency's jars for compilation 

    If the `java-library` plugin is applied, Gradle will compile against
the dependency's classes dir instead of building the jar and compiling
against the jar. This is not good for bundles since Bnd can pull in code
from other places and also set the package metadata.

So we configure the sourceSet's compileClasspath configuration to use
jars for compilation.

This support requires Gradle 5.6 or later.

See https://docs.gradle.org/current/userguide/java_library_plugin.html#sec:java_library_classes_usage

Signed-off-by: BJ Hargrave <bj@bjhargrave.com>
    @bjhargrave
    bjhargrave committed Dec 9, 2019
    Configuration menu
    Copy the full SHA
    0a7132f View commit details
    Browse the repository at this point in the history