Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add EE.getReleaseTarget() method #5358

Merged
merged 2 commits into from
Aug 25, 2022
Merged

Add EE.getReleaseTarget() method #5358

merged 2 commits into from
Aug 25, 2022

Conversation

laeubi
Copy link
Contributor

@laeubi laeubi commented Aug 24, 2022

@timothyjward as suggested in #5357 (comment)

bjhargrave
bjhargrave requested changes Aug 24, 2022
View reviewed changes
Copy link
Member

@bjhargrave bjhargrave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, EETest needs updating to test the new release target method.

biz.aQute.bndlib/src/aQute/bnd/build/model/EE.java Outdated Show resolved Hide resolved
biz.aQute.bndlib/src/aQute/bnd/build/model/EE.java Outdated Show resolved Hide resolved
biz.aQute.bndlib/src/aQute/bnd/build/model/EE.java Outdated Show resolved Hide resolved
@laeubi
Add EE.getRelease() method
124db32 
Signed-off-by: Christoph Läubrich <laeubi@laeubi-soft.de>
@laeubi
Copy link
Contributor Author

laeubi commented Aug 24, 2022

Also, EETest needs updating to test the new release target method.

Test adjusted as well.

@laeubi laeubi requested review from bjhargrave and timothyjward and removed request for bjhargrave August 24, 2022 18:12
bjhargrave
bjhargrave requested changes Aug 24, 2022
View reviewed changes
Copy link
Member

@bjhargrave bjhargrave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should use assertj tests.

biz.aQute.bndlib.tests/test/test/model/EETest.java Outdated Show resolved Hide resolved
biz.aQute.bndlib.tests/test/test/model/EETest.java Outdated Show resolved Hide resolved
biz.aQute.bndlib.tests/test/test/model/EETest.java Outdated Show resolved Hide resolved
biz.aQute.bndlib.tests/test/test/model/EETest.java Outdated Show resolved Hide resolved
biz.aQute.bndlib.tests/test/test/model/EETest.java Outdated Show resolved Hide resolved
biz.aQute.bndlib.tests/test/test/model/EETest.java Outdated Show resolved Hide resolved
biz.aQute.bndlib.tests/test/test/model/EETest.java Outdated Show resolved Hide resolved
biz.aQute.bndlib/src/aQute/bnd/build/model/EE.java Outdated Show resolved Hide resolved
@laeubi @bjhargrave
Apply suggestions from code review
33227e2 
Co-authored-by: BJ Hargrave <bj@hargrave.dev>
Signed-off-by: Christoph Läubrich <laeubi@laeubi-soft.de>
@laeubi
Copy link
Contributor Author

laeubi commented Aug 25, 2022

We should use assertj tests.

Done.

@laeubi laeubi mentioned this pull request Aug 25, 2022
Closed
@laeubi laeubi requested review from bjhargrave and timothyjward and removed request for timothyjward and bjhargrave August 25, 2022 17:37
@bjhargrave bjhargrave changed the title Add EE.getRelease() method Add EE.getReleaseTarget() method Aug 25, 2022
@bjhargrave bjhargrave merged commit 09c46ea into bndtools:master Aug 25, 2022
@laeubi
Copy link
Contributor Author

laeubi commented Aug 25, 2022

@bjhargrave @timothyjward thanks for the review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timothyjward timothyjward timothyjward left review comments

@bjhargrave bjhargrave bjhargrave approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@laeubi @bjhargrave @timothyjward