maven: Document access to Maven properties in Bnd instructions #5379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes bndtools#5375 Signed-off-by: BJ Hargrave <bj@hargrave.dev>
kwin
reviewed
Sep 26, 2022
| <groupId>biz.aQute.bnd</groupId> | ||
| <artifactId>bnd-maven-plugin</artifactId> | ||
| <configuration> | ||
| <bnd><
There was a problem hiding this comment.
@bjhargrave maybe this is not the best example, as with inline bnd instructions the replacement is actually done by Maven (https://maven.apache.org/ref/3.8.6/maven-model-builder/#model-interpolation). Only for external bnd files it is done by the bnd-maven-plugin IIUC.
There was a problem hiding this comment.
Perhaps you can make a PR to improve the example?
There was a problem hiding this comment.
Either split up the example to show both pom.xml and bnd.bnd or get rid of it alltogether I would say. But referencing https://maven.apache.org/ref/current/maven-model-builder/#model-interpolation in this context would be beneficial, as it works similarly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5375