Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove migrated pdetools.pde project #5887

Closed
wants to merge 1 commit into from

Conversation

laeubi
Copy link
Contributor

@laeubi laeubi commented Nov 13, 2023

This removes the code migrated to PDE here:

once the PDE part is merged this can be merged as features from this project will then be provided by PDE directly

Signed-off-by: Christoph Läubrich <laeubi@laeubi-soft.de>
@laeubi
Copy link
Contributor Author

laeubi commented Nov 15, 2023

I could need some help how to make the build happy ...

@pkriens
Copy link
Member

pkriens commented Nov 15, 2023

It craters at building the p2 repository. My assumption is that you did not remove the bndtools.pde feature that lists this as bundle/plugin? You can run gradle in the bndtools.p2 project with the p2 target to see if this is the case. The output is probably somewhere uploaded but this might be faster.

Which raises a question. I'd prefer if you deprecate these files/project/feature. I'd like to wait one or two releases before removing anything permanently. I haven't looked into details but do we handle the case some people have an older Eclipse/PDE installed when installing bndtools 7.1.0? I do not want to force them to upgrade.

@laeubi laeubi closed this Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants