Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade SWT to 3.126 to fix MacOS / JDK bug #6186

Merged

Conversation

chrisrueger
Copy link
Contributor

Closes #6185

It seems we can stay on older Eclipse 4.25 but use a higher SWT version which has fixed the SWT bug (see eclipse-platform/eclipse.platform.swt#1012).

With this fix I was able to use Eclipse with latest Temurin JDKs like

  • OpenJDK Runtime Environment Temurin-17.0.11+9
  • OpenJDK Runtime Environment Temurin-21.0.3+9

and it looks as usual again:

Bildschirmfoto 2024-07-17 um 16 36 23 Bildschirmfoto 2024-07-17 um 16 36 56

It seems we can stay on older Eclipse 4.25 but use a higher SWT version which has fixed the SWT bug (see eclipse-platform/eclipse.platform.swt#1012).

Signed-off-by: Christoph Rueger <chrisrueger@gmail.com>
@chrisrueger chrisrueger force-pushed the fix-macos-sonoma-eclipse-swt-bug branch from d1b3d6d to 92dedc9 Compare July 17, 2024 14:50
@chrisrueger
Copy link
Contributor Author

chrisrueger commented Jul 17, 2024

I did some local testing with an M1 and M3 Macbook (aarch64)

  • Temurin-17.0.11+9
  • Temurin-21.0.3+9

and I could not see any issues. Tested the usual screens like e.g.

  • bnd editor
  • resolution view
  • Repo Brower + Advanced Search
  • .bndrun editor
  • build.bnd editor
  • resolve dialog in bndrun editor
    • Button to add bundles to runbundles / runrequirements

same for intel macs

Signed-off-by: Christoph Rueger <chrisrueger@gmail.com>
@chrisrueger chrisrueger force-pushed the fix-macos-sonoma-eclipse-swt-bug branch from c38e285 to ccf9616 Compare July 17, 2024 19:27
Signed-off-by: Christoph Rueger <chrisrueger@gmail.com>
@chrisrueger
Copy link
Contributor Author

chrisrueger commented Jul 18, 2024

Did another test with an Intel Mac (but MacOs 13.x Ventura) and x_86 Temurin JDK
Ventura did not have the initial problem reported here.
But I can confirm that this PR did not break this.

@chrisrueger
Copy link
Contributor Author

@pkriens I would like to merge this. The problem should happen for 7.0.0 bndtools users using a Eclipse Temurin JDK in combination with latest MacOS Sonoma. In this case at least we could tell them to use the latest 7.1 Snapshot as another workaround (instead of using a special JDK which does not have this problem).

@pkriens
Copy link
Member

pkriens commented Jul 19, 2024

I am ok to merge. Thanks for the work!

@chrisrueger chrisrueger merged commit f2d02a3 into bndtools:master Jul 19, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issues with bndtools Eclipse dev instance on MacOS Sonoma 14.3+ with temurin JDK > 17.0.09+9
2 participants