Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove fixed bnd workspace problem markers from Problem view again #6383

Conversation

chrisrueger
Copy link
Contributor

@chrisrueger chrisrueger commented Dec 2, 2024

This fixes an annoyance, that Bndtools Workspace Problem Markers in /cnf/build.bnd where not removed from Eclipse's Problem-View, although you have fixed a problem. The reason was that model.getErrors() and model.getWarnings() used by org.bndtools.builder.MarkerSupport.setMarkers(Processor, String) where never cleared, so the errors and warnings where always re-added.

@pkriens we just talked about this today

Example / Testing

  1. Make a syntax error in /cnf/build.bnd
  2. check Eclipse's Problem view that it creates an error marker of type Bndtools Workspace Problem Marker
image
  1. Now fix the syntax error.

Expected behavior:

  • The marker should also be removed from Eclipse's Problem view

Actual behavior before fix:

  • the marker stayed there (in fact it was deleted but re-added...but very quickly)

This fixes an annoyance, that Bndtools Workspace Problem Markers in /cnf/build.bnd where not removed from Eclipse's Problem-View, although you have fixed a problem.
The reason was that model.getErrors() and model.getWarnings() used by org.bndtools.builder.MarkerSupport.setMarkers(Processor, String) where never cleared, so the errors and warnings where always re-added.

Signed-off-by: Christoph Rueger <chrisrueger@gmail.com>
@chrisrueger chrisrueger changed the title Remove fixed bnd workspace problem markers Remove fixed bnd workspace problem markers from Problem view again Dec 2, 2024
@pkriens
Copy link
Member

pkriens commented Dec 5, 2024

LGTM

@chrisrueger chrisrueger merged commit f5baa68 into bndtools:master Dec 5, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants