Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add workspace ignore list #57

Merged
merged 4 commits into from
Dec 20, 2022
Merged

Add workspace ignore list #57

merged 4 commits into from
Dec 20, 2022

Conversation

nanocryk
Copy link
Contributor

Fixes #56

@nanocryk
Copy link
Contributor Author

Could you take a look when you have time @bnjbvr ? :)

@bnjbvr
Copy link
Owner

bnjbvr commented Dec 19, 2022

Yep, sorry for the slow response time! Last week was a bit hectic. I will try to take a look this week.

@nanocryk
Copy link
Contributor Author

Hmm one issue I now encounter is that if I list a package to be ignore in the workspace, if in some crate it is indeed detected as used I have a warning. So maybe it would be better to store the workspace list separately so that no warnings are generated from them?

@nanocryk
Copy link
Contributor Author

Made the change I commented about above :)

bnjbvr
bnjbvr approved these changes Dec 20, 2022
View reviewed changes
Copy link
Owner

@bnjbvr bnjbvr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding a test too! looks good to me, and the new syntax and ignore rules make sense to me.

@bnjbvr bnjbvr merged commit d71068c into bnjbvr:main Dec 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bnjbvr bnjbvr bnjbvr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add ignore list in workspace Cargo.toml
2 participants
@nanocryk @bnjbvr