buffer: fix creating from zero-length ArrayBuffer

Fixes regression where creating a new Buffer from an empty ArrayBuffer would fail. Ref: nodejs@85ab4a5 PR-URL: nodejs#7176 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By: Ron Korving <ron@ronkorving.nl>
bnoordhuis · Jul 18, 2016 · 3b767b8 · 3b767b8
1 parent f0d9610
commit 3b767b8
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/lib/buffer.js b/lib/buffer.js
@@ -218,7 +218,7 @@ function fromArrayBuffer(obj, byteOffset, length) {
 
   const maxLength = obj.byteLength - byteOffset;
 
-  if (maxLength <= 0)
+  if (maxLength < 0)
     throw new RangeError("'offset' is out of bounds");
 
   if (length === undefined) {

diff --git a/test/parallel/test-buffer-alloc.js b/test/parallel/test-buffer-alloc.js
@@ -1458,3 +1458,8 @@ const ubuf = Buffer.allocUnsafeSlow(10);
 assert(ubuf);
 assert(ubuf.buffer);
 assert.equal(ubuf.buffer.byteLength, 10);
+
+// Regression test
+assert.doesNotThrow(() => {
+  Buffer.from(new ArrayBuffer());
+});