Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

W7 x64 MSBuild #102

Closed
jmparatte opened this issue Dec 13, 2014 · 5 comments
Closed

W7 x64 MSBuild #102

jmparatte opened this issue Dec 13, 2014 · 5 comments

Comments

@jmparatte
Copy link

Hi,

I'm configuring a new pc and reinstalling nodejs.
In the past I installed iconv with npm without problems, last time 2014-04-23.
Today it's a vera hard task...

First. I installed Visual Studio 2013 for Desktop, necessary to install another package: serialport. No problems, easy.

1st try to install iconv:

C:\develop\nodejs\node_modules\iconv>node "C:\Program Files\nodejs\node_modules\
npm\bin\node-gyp-bin\\..\..\node_modules\node-gyp\bin\node-gyp.js" rebuild
Génération des projets individuellement dans cette solution. Pour activer la gén
ération en parallèle, ajoutez le commutateur "/m".
C:\Program Files (x86)\MSBuild\Microsoft.Cpp\v4.0\V120\Microsoft.Cpp.Platform.t
argets(64,5): error MSB8020: The build tools for Visual Studio 2010 (Platform T
oolset = 'v100') cannot be found. To build using the v100 build tools, please i
nstall Visual Studio 2010 build tools.  Alternatively, you may upgrade to the c
urrent Visual Studio tools by selecting the Project menu or right-click the sol
ution, and then selecting "Upgrade Solution...". [C:\develop\nodejs\node_module
s\iconv\build\libiconv.vcxproj]
gyp ERR! build error
gyp ERR! stack Error: `C:\Program Files (x86)\MSBuild\12.0\bin\msbuild.exe` fail
ed with exit code: 1
gyp ERR! stack     at ChildProcess.onExit (C:\Program Files\nodejs\node_modules\
npm\node_modules\node-gyp\lib\build.js:267:23)
gyp ERR! stack     at ChildProcess.emit (events.js:98:17)
gyp ERR! stack     at Process.ChildProcess._handle.onexit (child_process.js:810:
12)
gyp ERR! System Windows_NT 6.1.7601
gyp ERR! command "node" "C:\\Program Files\\nodejs\\node_modules\\npm\\node_modu
les\\node-gyp\\bin\\node-gyp.js" "rebuild"
gyp ERR! cwd C:\develop\nodejs\node_modules\iconv
gyp ERR! node -v v0.10.33
gyp ERR! node-gyp -v v1.0.1
gyp ERR! not ok

npm ERR! iconv@2.1.4 install: `node-gyp rebuild`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the iconv@2.1.4 install script.
npm ERR! This is most likely a problem with the iconv package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     node-gyp rebuild
npm ERR! You can get their info via:
npm ERR!     npm owner ls iconv
npm ERR! There is likely additional logging output above.
npm ERR! System Windows_NT 6.1.7601
npm ERR! command "C:\\Program Files\\nodejs\\\\node.exe" "C:\\Program Files\\nod
ejs\\node_modules\\npm\\bin\\npm-cli.js" "install" "iconv"
npm ERR! cwd C:\develop\nodejs
npm ERR! node -v v0.10.33
npm ERR! npm -v 1.4.28
npm ERR! code ELIFECYCLE
npm ERR! not ok code 0

What I understood is that iconv looks for a previous VS2010. 
I tried to solve the problem by installing Visual C++ 2010 Express but without success.
Finally I downloaded Visual_Studio2010_Professional_x86_x16-81637.iso 2.2GB and installed it.

2nd try to install iconv:

C:\develop\nodejs>npm install iconv
/
> iconv@2.1.4 install C:\develop\nodejs\node_modules\iconv
> node-gyp rebuild


C:\develop\nodejs\node_modules\iconv>node "C:\Program Files\nodejs\node_modules\
npm\bin\node-gyp-bin\\..\..\node_modules\node-gyp\bin\node-gyp.js" rebuild
Génération des projets individuellement dans cette solution. Pour activer la gén
ération en parallèle, ajoutez le commutateur "/m".
  iconv.c
..\deps\libiconv\lib\iconv.c(52): warning C4005: 'USE_DOS' : macro redefinition
 [C:\develop\nodejs\node_modules\iconv\build\libiconv.vcxproj]
          command-line arguments :  see previous definition of 'USE_DOS'
c:\develop\nodejs\node_modules\iconv\deps\libiconv\lib\utf7.h(162): warning C40
18: '<' : signed/unsigned mismatch [C:\develop\nodejs\node_modules\iconv\build\
libiconv.vcxproj]
c:\develop\nodejs\node_modules\iconv\deps\libiconv\lib\utf7.h(331): warning C40
18: '<' : signed/unsigned mismatch [C:\develop\nodejs\node_modules\iconv\build\
libiconv.vcxproj]
c:\develop\nodejs\node_modules\iconv\deps\libiconv\lib\johab_hangul.h(253): war
ning C4244: 'return' : conversion from '__int64' to 'int', possible loss of dat
a [C:\develop\nodejs\node_modules\iconv\build\libiconv.vcxproj]
c:\develop\nodejs\node_modules\iconv\deps\libiconv\lib\hz.h(39): warning C4018:
 '<' : signed/unsigned mismatch [C:\develop\nodejs\node_modules\iconv\build\lib
iconv.vcxproj]
c:\develop\nodejs\node_modules\iconv\deps\libiconv\lib\hz.h(51): warning C4018:
 '<' : signed/unsigned mismatch [C:\develop\nodejs\node_modules\iconv\build\lib
iconv.vcxproj]
c:\develop\nodejs\node_modules\iconv\deps\libiconv\lib\hz.h(57): warning C4018:
 '<' : signed/unsigned mismatch [C:\develop\nodejs\node_modules\iconv\build\lib
iconv.vcxproj]
c:\develop\nodejs\node_modules\iconv\deps\libiconv\lib\hz.h(65): warning C4018:
 '<' : signed/unsigned mismatch [C:\develop\nodejs\node_modules\iconv\build\lib
iconv.vcxproj]
c:\develop\nodejs\node_modules\iconv\deps\libiconv\lib\hz.h(80): warning C4018:
 '<' : signed/unsigned mismatch [C:\develop\nodejs\node_modules\iconv\build\lib
iconv.vcxproj]
c:\develop\nodejs\node_modules\iconv\deps\libiconv\lib\loop_unicode.h(44): warn
ing C4267: 'function' : conversion from 'size_t' to 'int', possible loss of dat
a [C:\develop\nodejs\node_modules\iconv\build\libiconv.vcxproj]
c:\develop\nodejs\node_modules\iconv\deps\libiconv\lib\loop_unicode.h(50): warn
ing C4244: 'return' : conversion from '__int64' to 'int', possible loss of data
 [C:\develop\nodejs\node_modules\iconv\build\libiconv.vcxproj]
c:\develop\nodejs\node_modules\iconv\deps\libiconv\lib\loop_unicode.h(88): warn
ing C4267: 'function' : conversion from 'size_t' to 'int', possible loss of dat
a [C:\develop\nodejs\node_modules\iconv\build\libiconv.vcxproj]
c:\develop\nodejs\node_modules\iconv\deps\libiconv\lib\loop_unicode.h(94): warn
ing C4244: 'return' : conversion from '__int64' to 'int', possible loss of data
 [C:\develop\nodejs\node_modules\iconv\build\libiconv.vcxproj]
c:\develop\nodejs\node_modules\iconv\deps\libiconv\lib\loop_unicode.h(116): war
ning C4267: 'function' : conversion from 'size_t' to 'int', possible loss of da
ta [C:\develop\nodejs\node_modules\iconv\build\libiconv.vcxproj]
c:\develop\nodejs\node_modules\iconv\deps\libiconv\lib\loop_unicode.h(136): war
ning C4267: 'function' : conversion from 'size_t' to 'int', possible loss of da
ta [C:\develop\nodejs\node_modules\iconv\build\libiconv.vcxproj]
c:\develop\nodejs\node_modules\iconv\deps\libiconv\lib\loop_unicode.h(145): war
ning C4244: 'return' : conversion from '__int64' to 'int', possible loss of dat
a [C:\develop\nodejs\node_modules\iconv\build\libiconv.vcxproj]
c:\develop\nodejs\node_modules\iconv\deps\libiconv\lib\loop_unicode.h(208): war
ning C4267: 'function' : conversion from 'size_t' to 'int', possible loss of da
ta [C:\develop\nodejs\node_modules\iconv\build\libiconv.vcxproj]
c:\develop\nodejs\node_modules\iconv\deps\libiconv\lib\loop_unicode.h(244): war
ning C4267: 'function' : conversion from 'size_t' to 'int', possible loss of da
ta [C:\develop\nodejs\node_modules\iconv\build\libiconv.vcxproj]
c:\develop\nodejs\node_modules\iconv\deps\libiconv\lib\loop_unicode.h(284): war
ning C4267: 'function' : conversion from 'size_t' to 'int', possible loss of da
ta [C:\develop\nodejs\node_modules\iconv\build\libiconv.vcxproj]
c:\develop\nodejs\node_modules\iconv\deps\libiconv\lib\loop_unicode.h(362): war
ning C4267: 'function' : conversion from 'size_t' to 'int', possible loss of da
ta [C:\develop\nodejs\node_modules\iconv\build\libiconv.vcxproj]
c:\develop\nodejs\node_modules\iconv\deps\libiconv\lib\loop_unicode.h(400): war
ning C4267: 'function' : conversion from 'size_t' to 'int', possible loss of da
ta [C:\develop\nodejs\node_modules\iconv\build\libiconv.vcxproj]
c:\develop\nodejs\node_modules\iconv\deps\libiconv\lib\loop_unicode.h(449): war
ning C4267: 'function' : conversion from 'size_t' to 'int', possible loss of da
ta [C:\develop\nodejs\node_modules\iconv\build\libiconv.vcxproj]
c:\develop\nodejs\node_modules\iconv\deps\libiconv\lib\loop_unicode.h(487): war
ning C4267: 'function' : conversion from 'size_t' to 'int', possible loss of da
ta [C:\develop\nodejs\node_modules\iconv\build\libiconv.vcxproj]
c:\develop\nodejs\node_modules\iconv\deps\libiconv\lib\loop_unicode.h(514): war
ning C4267: 'function' : conversion from 'size_t' to 'int', possible loss of da
ta [C:\develop\nodejs\node_modules\iconv\build\libiconv.vcxproj]
c:\develop\nodejs\node_modules\iconv\deps\libiconv\lib\iconv_open1.h(77): warni
ng C4003: not enough actual parameters for macro 'locale_charset' [C:\develop\n
odejs\node_modules\iconv\build\libiconv.vcxproj]
c:\develop\nodejs\node_modules\iconv\deps\libiconv\lib\iconv_open1.h(84): warni
ng C4244: 'function' : conversion from '__int64' to 'unsigned int', possible lo
ss of data [C:\develop\nodejs\node_modules\iconv\build\libiconv.vcxproj]
c:\develop\nodejs\node_modules\iconv\deps\libiconv\lib\iconv_open1.h(91): warni
ng C4003: not enough actual parameters for macro 'locale_charset' [C:\develop\n
odejs\node_modules\iconv\build\libiconv.vcxproj]
c:\develop\nodejs\node_modules\iconv\deps\libiconv\lib\iconv_open1.h(167): warn
ing C4003: not enough actual parameters for macro 'locale_charset' [C:\develop\
nodejs\node_modules\iconv\build\libiconv.vcxproj]
c:\develop\nodejs\node_modules\iconv\deps\libiconv\lib\iconv_open1.h(174): warn
ing C4244: 'function' : conversion from '__int64' to 'unsigned int', possible l
oss of data [C:\develop\nodejs\node_modules\iconv\build\libiconv.vcxproj]
c:\develop\nodejs\node_modules\iconv\deps\libiconv\lib\iconv_open1.h(181): warn
ing C4003: not enough actual parameters for macro 'locale_charset' [C:\develop\
nodejs\node_modules\iconv\build\libiconv.vcxproj]
c:\develop\nodejs\node_modules\iconv\deps\libiconv\lib\iconv_open1.h(77): warni
ng C4003: not enough actual parameters for macro 'locale_charset' [C:\develop\n
odejs\node_modules\iconv\build\libiconv.vcxproj]
c:\develop\nodejs\node_modules\iconv\deps\libiconv\lib\iconv_open1.h(84): warni
ng C4244: 'function' : conversion from '__int64' to 'unsigned int', possible lo
ss of data [C:\develop\nodejs\node_modules\iconv\build\libiconv.vcxproj]
c:\develop\nodejs\node_modules\iconv\deps\libiconv\lib\iconv_open1.h(91): warni
ng C4003: not enough actual parameters for macro 'locale_charset' [C:\develop\n
odejs\node_modules\iconv\build\libiconv.vcxproj]
c:\develop\nodejs\node_modules\iconv\deps\libiconv\lib\iconv_open1.h(167): warn
ing C4003: not enough actual parameters for macro 'locale_charset' [C:\develop\
nodejs\node_modules\iconv\build\libiconv.vcxproj]
c:\develop\nodejs\node_modules\iconv\deps\libiconv\lib\iconv_open1.h(174): warn
ing C4244: 'function' : conversion from '__int64' to 'unsigned int', possible l
oss of data [C:\develop\nodejs\node_modules\iconv\build\libiconv.vcxproj]
c:\develop\nodejs\node_modules\iconv\deps\libiconv\lib\iconv_open1.h(181): warn
ing C4003: not enough actual parameters for macro 'locale_charset' [C:\develop\
nodejs\node_modules\iconv\build\libiconv.vcxproj]
..\deps\libiconv\lib\iconv.c(426): warning C4090: 'function' : different 'const
' qualifiers [C:\develop\nodejs\node_modules\iconv\build\libiconv.vcxproj]
..\deps\libiconv\lib\iconv.c(428): warning C4267: 'function' : conversion from
'size_t' to 'unsigned int', possible loss of data [C:\develop\nodejs\node_modul
es\iconv\build\libiconv.vcxproj]
..\deps\libiconv\lib\iconv.c(530): warning C4003: not enough actual parameters
for macro 'locale_charset' [C:\develop\nodejs\node_modules\iconv\build\libiconv
.vcxproj]
..\deps\libiconv\lib\iconv.c(538): warning C4244: 'function' : conversion from
'__int64' to 'unsigned int', possible loss of data [C:\develop\nodejs\node_modu
les\iconv\build\libiconv.vcxproj]
..\deps\libiconv\lib\iconv.c(546): warning C4003: not enough actual parameters
for macro 'locale_charset' [C:\develop\nodejs\node_modules\iconv\build\libiconv
.vcxproj]
  libiconv.vcxproj -> C:\develop\nodejs\node_modules\iconv\build\Release\\libic
  onv.lib
  binding.cc
C:\develop\nodejs\node_modules\iconv\node_modules\nan\nan.h(1174): warning C426
7: '=' : conversion from 'size_t' to 'int', possible loss of data [C:\develop\n
odejs\node_modules\iconv\build\iconv.vcxproj]
C:\develop\nodejs\node_modules\iconv\node_modules\nan\nan.h(1191): warning C426
7: '=' : conversion from 'size_t' to 'int', possible loss of data [C:\develop\n
odejs\node_modules\iconv\build\iconv.vcxproj]
C:\develop\nodejs\node_modules\iconv\node_modules\nan\nan.h(1204): warning C426
7: 'initializing' : conversion from 'size_t' to 'int', possible loss of data [C
:\develop\nodejs\node_modules\iconv\build\iconv.vcxproj]
C:\develop\nodejs\node_modules\iconv\node_modules\nan\nan.h(1218): warning C426
7: 'initializing' : conversion from 'size_t' to 'int', possible loss of data [C
:\develop\nodejs\node_modules\iconv\build\iconv.vcxproj]
C:\develop\nodejs\node_modules\iconv\node_modules\nan\nan.h(1307): warning C424
4: 'return' : conversion from 'intptr_t' to 'int', possible loss of data [C:\de
velop\nodejs\node_modules\iconv\build\iconv.vcxproj]
C:\develop\nodejs\node_modules\iconv\node_modules\nan\nan.h(1053): warning C426
7: 'argument' : conversion from 'size_t' to 'int32_t', possible loss of data [C
:\develop\nodejs\node_modules\iconv\build\iconv.vcxproj]
          ..\src\binding.cc(121) : see reference to function template instantia
  tion 'v8::Local<T> NanNew<v8::Integer,size_t>(P)' being compiled
          with
          [
              T=v8::Integer,
              P=size_t
          ]
C:\Users\jmparatte\.node-gyp\0.10.33\deps\v8\include\v8.h(179): warning C4506:
no definition for inline function 'v8::Persistent<T> v8::Persistent<T>::New(v8:
:Handle<T>)' [C:\develop\nodejs\node_modules\iconv\build\iconv.vcxproj]
          with
          [
              T=v8::Object
          ]
     Creating library C:\develop\nodejs\node_modules\iconv\build\Release\iconv.
  lib and object C:\develop\nodejs\node_modules\iconv\build\Release\iconv.exp
  Generating code
  Finished generating code
  iconv.vcxproj -> C:\develop\nodejs\node_modules\iconv\build\Release\\iconv.no
  de
iconv@2.1.4 node_modules\iconv
└── nan@1.1.2

C:\develop\nodejs>

As you can read it, there are a lot of warnings compiling nan.h file.
How to solve them ?
Can you update the package to use VS2013 instead of 2010 ?

Best regards.

@bnoordhuis
Copy link
Owner

As you can read it, there are a lot of warnings compiling nan.h file. How to solve them ?

Can you try updating the nan version in package.json, then run npm install again? I think those warnings were fixed in a recent release. The warnings that originate from the bundled iconv are just a fact of life, maybe excepting the USE_DOS and locale_charset warnings.

Can you update the package to use VS2013 instead of 2010 ?

The VS version is auto-detected by gyp / node-gyp (the build system for node.js add-ons), not node-iconv. You can override it by passing --msvs_version=2013 (2013e for VS Express) to npm install.

@jmparatte
Copy link
Author

Can you try updating the nan version in package.json, then run npm install again?

Can you explain howto load the package, edit the package, build the package, how to break npm install ?

@bnoordhuis
Copy link
Owner

Just clone the repo; the package.json in the usual place, the top-level directory. You run npm install from the same directory.

@jmparatte
Copy link
Author

OK. I've updated package.json, for ´nan´ and ´tap´:

C:\develop\nodejs>cd node-iconv

C:\develop\nodejs\node-iconv>npm install

iconv@2.1.4 install C:\develop\nodejs\node-iconv
node-gyp rebuild

C:\develop\nodejs\node-iconv>node "C:\Program Files\nodejs\node_modules\npm\bin
node-gyp-bin....\node_modules\node-gyp\bin\node-gyp.js" rebuild
Génération des projets individuellement dans cette solution. Pour activer la gén
ération en parallèle, ajoutez le commutateur "/m".
iconv.c
..\deps\libiconv\lib\iconv.c(52): warning C4005: 'USE_DOS' : macro redefinition
[C:\develop\nodejs\node-iconv\build\libiconv.vcxproj]
command-line arguments : see previous definition of 'USE_DOS'
c:\develop\nodejs\node-iconv\deps\libiconv\lib\utf7.h(162): warning C4018: '<'
: signed/unsigned mismatch [C:\develop\nodejs\node-iconv\build\libiconv.vcxproj
]
c:\develop\nodejs\node-iconv\deps\libiconv\lib\utf7.h(331): warning C4018: '<'
: signed/unsigned mismatch [C:\develop\nodejs\node-iconv\build\libiconv.vcxproj
]
c:\develop\nodejs\node-iconv\deps\libiconv\lib\johab_hangul.h(253): warning C42
44: 'return' : conversion from '__int64' to 'int', possible loss of data [C:\de
velop\nodejs\node-iconv\build\libiconv.vcxproj]
c:\develop\nodejs\node-iconv\deps\libiconv\lib\hz.h(39): warning C4018: '<' : s
igned/unsigned mismatch [C:\develop\nodejs\node-iconv\build\libiconv.vcxproj]
c:\develop\nodejs\node-iconv\deps\libiconv\lib\hz.h(51): warning C4018: '<' : s
igned/unsigned mismatch [C:\develop\nodejs\node-iconv\build\libiconv.vcxproj]
c:\develop\nodejs\node-iconv\deps\libiconv\lib\hz.h(57): warning C4018: '<' : s
igned/unsigned mismatch [C:\develop\nodejs\node-iconv\build\libiconv.vcxproj]
c:\develop\nodejs\node-iconv\deps\libiconv\lib\hz.h(65): warning C4018: '<' : s
igned/unsigned mismatch [C:\develop\nodejs\node-iconv\build\libiconv.vcxproj]
c:\develop\nodejs\node-iconv\deps\libiconv\lib\hz.h(80): warning C4018: '<' : s
igned/unsigned mismatch [C:\develop\nodejs\node-iconv\build\libiconv.vcxproj]
c:\develop\nodejs\node-iconv\deps\libiconv\lib\loop_unicode.h(44): warning C426
7: 'function' : conversion from 'size_t' to 'int', possible loss of data [C:\de
velop\nodejs\node-iconv\build\libiconv.vcxproj]
c:\develop\nodejs\node-iconv\deps\libiconv\lib\loop_unicode.h(50): warning C424
4: 'return' : conversion from '__int64' to 'int', possible loss of data [C:\dev
elop\nodejs\node-iconv\build\libiconv.vcxproj]
c:\develop\nodejs\node-iconv\deps\libiconv\lib\loop_unicode.h(88): warning C426
7: 'function' : conversion from 'size_t' to 'int', possible loss of data [C:\de
velop\nodejs\node-iconv\build\libiconv.vcxproj]
c:\develop\nodejs\node-iconv\deps\libiconv\lib\loop_unicode.h(94): warning C424
4: 'return' : conversion from '__int64' to 'int', possible loss of data [C:\dev
elop\nodejs\node-iconv\build\libiconv.vcxproj]
c:\develop\nodejs\node-iconv\deps\libiconv\lib\loop_unicode.h(116): warning C42
67: 'function' : conversion from 'size_t' to 'int', possible loss of data [C:\d
evelop\nodejs\node-iconv\build\libiconv.vcxproj]
c:\develop\nodejs\node-iconv\deps\libiconv\lib\loop_unicode.h(136): warning C42
67: 'function' : conversion from 'size_t' to 'int', possible loss of data [C:\d
evelop\nodejs\node-iconv\build\libiconv.vcxproj]
c:\develop\nodejs\node-iconv\deps\libiconv\lib\loop_unicode.h(145): warning C42
44: 'return' : conversion from '__int64' to 'int', possible loss of data [C:\de
velop\nodejs\node-iconv\build\libiconv.vcxproj]
c:\develop\nodejs\node-iconv\deps\libiconv\lib\loop_unicode.h(208): warning C42
67: 'function' : conversion from 'size_t' to 'int', possible loss of data [C:\d
evelop\nodejs\node-iconv\build\libiconv.vcxproj]
c:\develop\nodejs\node-iconv\deps\libiconv\lib\loop_unicode.h(244): warning C42
67: 'function' : conversion from 'size_t' to 'int', possible loss of data [C:\d
evelop\nodejs\node-iconv\build\libiconv.vcxproj]
c:\develop\nodejs\node-iconv\deps\libiconv\lib\loop_unicode.h(284): warning C42
67: 'function' : conversion from 'size_t' to 'int', possible loss of data [C:\d
evelop\nodejs\node-iconv\build\libiconv.vcxproj]
c:\develop\nodejs\node-iconv\deps\libiconv\lib\loop_unicode.h(362): warning C42
67: 'function' : conversion from 'size_t' to 'int', possible loss of data [C:\d
evelop\nodejs\node-iconv\build\libiconv.vcxproj]
c:\develop\nodejs\node-iconv\deps\libiconv\lib\loop_unicode.h(400): warning C42
67: 'function' : conversion from 'size_t' to 'int', possible loss of data [C:\d
evelop\nodejs\node-iconv\build\libiconv.vcxproj]
c:\develop\nodejs\node-iconv\deps\libiconv\lib\loop_unicode.h(449): warning C42
67: 'function' : conversion from 'size_t' to 'int', possible loss of data [C:\d
evelop\nodejs\node-iconv\build\libiconv.vcxproj]
c:\develop\nodejs\node-iconv\deps\libiconv\lib\loop_unicode.h(487): warning C42
67: 'function' : conversion from 'size_t' to 'int', possible loss of data [C:\d
evelop\nodejs\node-iconv\build\libiconv.vcxproj]
c:\develop\nodejs\node-iconv\deps\libiconv\lib\loop_unicode.h(514): warning C42
67: 'function' : conversion from 'size_t' to 'int', possible loss of data [C:\d
evelop\nodejs\node-iconv\build\libiconv.vcxproj]
c:\develop\nodejs\node-iconv\deps\libiconv\lib\iconv_open1.h(84): warning C4244
: 'function' : conversion from '__int64' to 'unsigned int', possible loss of da
ta [C:\develop\nodejs\node-iconv\build\libiconv.vcxproj]
c:\develop\nodejs\node-iconv\deps\libiconv\lib\iconv_open1.h(174): warning C424
4: 'function' : conversion from '__int64' to 'unsigned int', possible loss of d
ata [C:\develop\nodejs\node-iconv\build\libiconv.vcxproj]
c:\develop\nodejs\node-iconv\deps\libiconv\lib\iconv_open1.h(84): warning C4244
: 'function' : conversion from '__int64' to 'unsigned int', possible loss of da
ta [C:\develop\nodejs\node-iconv\build\libiconv.vcxproj]
c:\develop\nodejs\node-iconv\deps\libiconv\lib\iconv_open1.h(174): warning C424
4: 'function' : conversion from '__int64' to 'unsigned int', possible loss of d
ata [C:\develop\nodejs\node-iconv\build\libiconv.vcxproj]
..\deps\libiconv\lib\iconv.c(426): warning C4090: 'function' : different 'const
' qualifiers [C:\develop\nodejs\node-iconv\build\libiconv.vcxproj]
..\deps\libiconv\lib\iconv.c(428): warning C4267: 'function' : conversion from
'size_t' to 'unsigned int', possible loss of data [C:\develop\nodejs\node-iconv
\build\libiconv.vcxproj]
..\deps\libiconv\lib\iconv.c(538): warning C4244: 'function' : conversion from
'__int64' to 'unsigned int', possible loss of data [C:\develop\nodejs\node-icon
v\build\libiconv.vcxproj]
libiconv.vcxproj -> C:\develop\nodejs\node-iconv\build\Release\libiconv.lib
binding.cc
C:\develop\nodejs\node-iconv\node_modules\nan\nan.h(1081): warning C4267: 'argu
ment' : conversion from 'size_t' to 'int32_t', possible loss of data [C:\develo
p\nodejs\node-iconv\build\iconv.vcxproj]
..\src\binding.cc(121) : see reference to function template instantia
tion 'v8::Local NanNewv8::Integer,size_t(P)' being compiled
with
[
T=v8::Integer,
P=size_t
]
C:\Users\jmparatte.node-gyp\0.10.33\deps\v8\include\v8.h(179): warning C4506:
no definition for inline function 'v8::Persistent v8::Persistent::New(v8:
:Handle)' [C:\develop\nodejs\node-iconv\build\iconv.vcxproj]
with
[
T=v8::Object
]
Creating library C:\develop\nodejs\node-iconv\build\Release\iconv.lib and
object C:\develop\nodejs\node-iconv\build\Release\iconv.exp
Generating code
Finished generating code
iconv.vcxproj -> C:\develop\nodejs\node-iconv\build\Release\iconv.node

C:\develop\nodejs\node-iconv>

bnoordhuis added a commit that referenced this issue Dec 14, 2014
USE_EXTRA implies USE_AIX, USE_DOS and USE_OSF1; there is no need
to define them explicitly.  Fixes macro redefinition warnings in
deps/libiconv/lib/iconv.c.

Remove LIBDIR, it's unused as of commit 03e7a1e.

Refs #102.
@bnoordhuis
Copy link
Owner

@jmparatte I landed some changes in e7053b2 and 2fb992b that should reduce the number of warnings. I can't upgrade nan right now because of nodejs/nan#222. I'm going to tentatively close this as fixed pending a new release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants