Apply review

boa_engine/src/builtins/date/mod.rs

@@ -34,8 +34,6 @@ macro_rules! some_or_nan {
 
 /// Gets a mutable reference to the inner `Date` object of `val` and stores it on `var`, or returns
 /// a `TypeError` if `val` is not a `Date` object.
-///
-/// [spec]: https://tc39.es/ecma262/#sec-thistimevalue
 macro_rules! get_mut_date {
     (let $var:ident = $val:expr) => {
         let mut $var = $val
@@ -64,14 +62,17 @@ pub(super) fn this_time_value(value: &JsValue) -> JsResult<Option<NaiveDateTime>
 pub struct Date(Option<NaiveDateTime>);
 
 impl Date {
+    #[inline]
+    /// Creates a new `Date`.
     pub(crate) fn new(dt: Option<NaiveDateTime>) -> Self {
         Self(dt)
     }
+
+    /// Converts the `Date` into a `JsValue`, mapping `None` to `NaN` and `Some(datetime)` to
+    /// `JsValue::from(datetime.timestamp_millis())`.
     fn as_value(&self) -> JsValue {
-        match self.0 {
-            Some(dt) => JsValue::from(dt.timestamp_millis()),
-            None => JsValue::from(f64::NAN),
-        }
+        self.0
+            .map_or_else(|| f64::NAN.into(), |dt| dt.timestamp_millis().into())
     }
 }
 

boa_engine/src/builtins/set/ordered_set.rs

@@ -91,6 +91,7 @@ where
     }
 
     /// Removes all elements in the set, while preserving its capacity.
+    #[inline]
     pub fn clear(&mut self) {
         self.inner.clear();
     }

boa_engine/src/vm/mod.rs

@@ -182,10 +182,10 @@ impl Context {
 
         while self.vm.frame().pc < self.vm.frame().code.code.len() {
             #[cfg(feature = "fuzz")]
-            #[allow(clippy::redundant_else)]
-            if self.instructions_remaining == 0 {
-                return Err(JsError::from_native(JsNativeError::no_instructions_remain()));
-            } else {
+            {
+                if self.instructions_remaining == 0 {
+                    return Err(JsError::from_native(JsNativeError::no_instructions_remain()));
+                }
                 self.instructions_remaining -= 1;
             }