Fix some typos and change HashSet to FxHashSet

boa-dev · Sep 30, 2021 · b459f1e · b459f1e
1 parent 8b5fadb
commit b459f1e
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 7 deletions.
diff --git a/boa/src/syntax/parser/expression/primary/mod.rs b/boa/src/syntax/parser/expression/primary/mod.rs
@@ -130,7 +130,7 @@ where
                 }
                 Ok(Identifier::from("yield").into())
             }
-            TokenKind::Keyword(Keyword::Await) if self.allow_yield.0 => {
+            TokenKind::Keyword(Keyword::Await) if self.allow_await.0 => {
                 // Early Error: It is a Syntax Error if this production has an [Await] parameter and StringValue of Identifier is "await".
                 Err(ParseError::general(
                     "Unexpected identifier",

diff --git a/boa/src/syntax/parser/expression/primary/object_initializer/mod.rs b/boa/src/syntax/parser/expression/primary/object_initializer/mod.rs
@@ -267,12 +267,12 @@ where
             return Ok(node::PropertyDefinition::property(property_name, value));
         }
 
-        let ordinary = cursor.peek(0)?.ok_or(ParseError::AbruptEnd)?.kind()
+        let ordinary_method = cursor.peek(0)?.ok_or(ParseError::AbruptEnd)?.kind()
             == &TokenKind::Punctuator(Punctuator::OpenParen);
 
         match property_name {
             // MethodDefinition[?Yield, ?Await] -> get ClassElementName[?Yield, ?Await] ( ) { FunctionBody[~Yield, ~Await] }
-            node::PropertyName::Literal(str) if str.as_ref() == "get" && !ordinary => {
+            node::PropertyName::Literal(str) if str.as_ref() == "get" && !ordinary_method => {
                 property_name =
                     PropertyName::new(self.allow_yield, self.allow_await).parse(cursor)?;
 
@@ -302,7 +302,7 @@ where
                 ))
             }
             // MethodDefinition[?Yield, ?Await] -> set ClassElementName[?Yield, ?Await] ( PropertySetParameterList ) { FunctionBody[~Yield, ~Await] }
-            node::PropertyName::Literal(str) if str.as_ref() == "set" && !ordinary => {
+            node::PropertyName::Literal(str) if str.as_ref() == "set" && !ordinary_method => {
                 property_name =
                     PropertyName::new(self.allow_yield, self.allow_await).parse(cursor)?;
 

diff --git a/boa/src/syntax/parser/function/mod.rs b/boa/src/syntax/parser/function/mod.rs
@@ -22,7 +22,8 @@ use crate::{
     },
     BoaProfiler,
 };
-use std::{collections::HashSet, io::Read};
+use rustc_hash::FxHashSet;
+use std::io::Read;
 
 /// Intermediate type for a list of FormalParameters with some meta information.
 pub(in crate::syntax::parser) struct FormalParameterList {
@@ -83,7 +84,7 @@ where
         }
         let start_position = next_token.span().start();
 
-        let mut parameter_names = HashSet::new();
+        let mut parameter_names = FxHashSet::default();
 
         loop {
             let mut rest_param = false;

diff --git a/boa/src/syntax/parser/statement/mod.rs b/boa/src/syntax/parser/statement/mod.rs
@@ -537,7 +537,7 @@ where
                     Ok("yield".into())
                 }
             }
-            TokenKind::Keyword(Keyword::Await) if self.allow_yield.0 => {
+            TokenKind::Keyword(Keyword::Await) if self.allow_await.0 => {
                 // Early Error: It is a Syntax Error if this production has an [Await] parameter and StringValue of Identifier is "await".
                 Err(ParseError::general(
                     "Unexpected identifier",