fix break labels, but don't reformat the whole tests file

boa-dev · Feb 23, 2022 · c1ce48e · c1ce48e
1 parent 8c92a8f
commit c1ce48e
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 7 deletions.
diff --git a/boa_engine/src/bytecompiler.rs b/boa_engine/src/bytecompiler.rs
@@ -1480,11 +1480,12 @@ impl<'b> ByteCompiler<'b> {
                             break;
                         }
                     }
-                    assert!(
-                        found,
-                        "Undefined label '{}'",
-                        self.interner().resolve_expect(label_name)
-                    );
+                    if !found {
+                        return self.context.throw_syntax_error(format!(
+                            "Undefined label '{}'",
+                            self.interner().resolve_expect(label_name)
+                        ));
+                    }
                 } else {
                     self.jump_info
                         .last_mut()

diff --git a/boa_engine/src/tests.rs b/boa_engine/src/tests.rs
@@ -431,15 +431,14 @@ fn for_loop_iteration_variable_does_not_leak() {
 }
 
 #[test]
-#[should_panic]
 fn test_invalid_break_target() {
     let src = r#"
         while (false) {
           break nonexistent;
         }
         "#;
 
-    let _ = &exec(src);
+    assert!(matches!(Context::default().eval(src.as_bytes()), Err(_)));
 }
 
 #[test]