-
-
Notifications
You must be signed in to change notification settings - Fork 420
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make WASM an opt-in feature #333
Comments
I also think this is a good idea as it would allow us to move the most of the webassembly stuff in that directory, making things more organized. And not having to specify that the |
Yep agree with the above it should be opt in rather than opt out. We can also move it to a wrapper crate |
I would like to take this one. But will only be able to work on it from next week, if that's ok. |
Sure, go ahead, let us know when you start! :) |
I can start now. |
Currently, webassembly is an opt-out feature. While we use it for the web example, I think in the future it will be more common for Boa to be used as a library than as webassembly.
In this scenario, I think it's best to make the feature opt-in, so that we don't need to use
default-features = false
when loading the crate as a library.This would mean that we need somehow to be able to select a feature in wasm-pack, or that we need a different crate only exporting boa as wasm, in the workspace, something like
boa-wasm
.I would go for this second option, as it also allows us to add
#![forbid(unsafe_code)]
at the crate level inboa
.What do you think?
The text was updated successfully, but these errors were encountered: