Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

create boa-wasm package #352

Merged
merged 2 commits into from
Apr 28, 2020
Merged

create boa-wasm package #352

merged 2 commits into from
Apr 28, 2020

Conversation

muskuloes
Copy link
Contributor

@Razican Razican added the webassembly Anything related to using Boa with WASM label Apr 28, 2020
@Razican Razican linked an issue Apr 28, 2020 that may be closed by this pull request
Make WASM an opt-in feature #333
Closed
Razican
Razican reviewed Apr 28, 2020
View reviewed changes
Copy link
Member

@Razican Razican left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great :) I would also remove default-features = false from the CLI app.

@muskuloes
Copy link
Contributor Author

The cli uses the serde-ast feature from boa lib.

@HalidOdat
Copy link
Member

HalidOdat commented Apr 28, 2020 •
edited
Loading

The cli uses the serde-ast feature from boa lib.

Removing default-features = false should not interfere with non-default features like serde-ast.

@muskuloes
Copy link
Contributor Author

muskuloes commented Apr 28, 2020 •
edited
Loading

The cli uses the serde-ast feature from boa lib.

Removing default-features = false should not interfere with non-default features like serde-ast.

You are right. I miss understood the documentation on that 😅
I updated the PR.

@HalidOdat HalidOdat added this to the v0.8.0 milestone Apr 28, 2020
HalidOdat
HalidOdat approved these changes Apr 28, 2020
View reviewed changes
Copy link
Member

@HalidOdat HalidOdat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks perfect to me!

Razican
Razican approved these changes Apr 28, 2020
View reviewed changes
Copy link
Member

@Razican Razican left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's merge it!

@Razican Razican merged commit 55c8576 into boa-dev:master Apr 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Razican Razican Razican approved these changes

@HalidOdat HalidOdat HalidOdat approved these changes

Assignees
No one assigned
Labels
webassembly Anything related to using Boa with WASM
Projects
None yet
Milestone
v0.8.0
Development

Successfully merging this pull request may close these issues.

Make WASM an opt-in feature
3 participants
@muskuloes @HalidOdat @Razican