Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve our GitHub pages site by not requiring vendored code #821

Closed
Razican opened this issue Oct 8, 2020 · 6 comments · Fixed by #834
Closed

Improve our GitHub pages site by not requiring vendored code #821

Razican opened this issue Oct 8, 2020 · 6 comments · Fixed by #834
Labels
documentation update documentation enhancement New feature or request
Milestone

Comments

@Razican
Copy link
Member

Razican commented Oct 8, 2020

We currently require Bootstrap and jQuery to be included in the GitHub pages branch. This is not ideal, and we should somehow just create a static page with a node_modules or with a webpacked script that includes all the requirements.

This should be available for both the Test262 test suite and for the benchmarks, that should then be linked from the demo and the main website.

@Razican Razican added the enhancement New feature or request label Oct 8, 2020
@neeldug
Copy link
Contributor

neeldug commented Oct 8, 2020

Couldn't this be done with a CDN instead of holding the assets locally? Unless you want updated versioning somehow, in which case it probably should be done with webpack.

@Razican
Copy link
Member Author

Razican commented Oct 8, 2020

Couldn't this be done with a CDN instead of holding the assets locally? Unless you want updated versioning somehow, in which case it probably should be done with webpack.

Indeed, that would probably be an easy improvement.

@neeldug
Copy link
Contributor

neeldug commented Oct 8, 2020

Indeed, that would probably be an easy improvement.

Also, I'm currently unable to see where jQuery's being included on the gh-pages branch. Any help on where to find it would be much appreciated!

@Razican
Copy link
Member Author

Razican commented Oct 8, 2020

Indeed, that would probably be an easy improvement.

Also, I'm currently unable to see where jQuery's being included on the gh-pages branch. Any help on where to find it would be much appreciated!

It's being included in #769.

@neeldug
Copy link
Contributor

neeldug commented Oct 8, 2020

It's being included in #769.

Alright, I see, I'll just wait for 769 to land before I make the changes since they aren't too urgent!

@Razican Razican added the documentation update documentation label Oct 9, 2020
@Razican Razican added this to the v0.11.0 milestone Oct 9, 2020
@neeldug
Copy link
Contributor

neeldug commented Oct 9, 2020

Rebase ended up pulling in loads of commits, so just created a fresh branch since changes were simple enough!

@RageKnify RageKnify linked a pull request Oct 9, 2020 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation update documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants