Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test262 results representation #769

Merged
merged 5 commits into from
Oct 9, 2020
Merged

Test262 results representation #769

merged 5 commits into from
Oct 9, 2020

Conversation

Razican
Copy link
Member

@Razican Razican commented Oct 2, 2020

This PR adds a visual representation to the ECMAScript test suite results, it closes #719.

I also added "Prettier" formatting for all the custom files in the gh-pages branch.

@Razican Razican added enhancement New feature or request test Issues and PRs related to the tests. labels Oct 2, 2020
@Razican Razican added this to the v0.11.0 milestone Oct 2, 2020
@Razican Razican linked an issue Oct 2, 2020 that may be closed by this pull request
@Razican
Copy link
Member Author

Razican commented Oct 3, 2020

A small peek on how this is looking:

Screenshot

Things I consider we should add:

  • version history on the right column (for now, only v0.10, but should add new ones automatically)
  • Graph to show the progress of the master branch.
  • Loading spinning icons for when it's taking some time to load (full result files are huge).
  • Add links to information about test262 test suite and how to interpret the results.

Things already present:

  • Latest version and master branch overview
  • Fine-grained view of the working/failing tests
  • Click on a given test to directly go to the test262 repo, to the actual test file source
  • Formatted the code to use Prettier format.
  • Automatic updates on every commit to master and after every release.
  • Progress bar for a visual representation on conformance.
  • passed/failed/ignored/panic information on test results.
  • Links to test262 sources in the specific commit.
  • Name of the test on hover.
  • Links to benchmarks and conformance results from the demo.

@Razican Razican force-pushed the test262_repr branch 2 times, most recently from f39bf65 to 96f5546 Compare October 5, 2020 18:14
test262/index.html Outdated Show resolved Hide resolved
@Razican
Copy link
Member Author

Razican commented Oct 8, 2020

I think this is ready for review. Some extra things can be added such as a graph for the master branch, but I think this is already pretty useful in the current form. I will open a couple of issues to:

  • Add a popover graph showing the progress of the master branch
  • Add the version history in the rightmost column
  • Rethink the gh-pages to not embed external libraries.

Copy link
Member

@HalidOdat HalidOdat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! :)

Maybe we should add the link in README.md, for easier access

@Razican Razican merged commit c062f7b into gh-pages Oct 9, 2020
@Razican Razican deleted the test262_repr branch October 9, 2020 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use test262 data to generate page to show our conformance
3 participants