Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

terminology - replace "statements" property in StatementList struct with "statement_list_items" #842

Closed
croraf opened this issue Oct 10, 2020 · 5 comments · Fixed by #1014
Closed

terminology - replace "statements" property in StatementList struct with "statement_list_items" #842

croraf opened this issue Oct 10, 2020 · 5 comments · Fixed by #1014

Comments

@croraf
Copy link
Contributor

croraf commented Oct 10, 2020 •
edited
Loading

This term will be more compliant with the standard.

These items can be both statements and declarations.
@croraf croraf changed the title terminology - replace "statements" property in StatementList struct with ""statement_list_item" terminology - replace "statements" property in StatementList struct with ""statement_list_items" Oct 10, 2020
@croraf croraf changed the title terminology - replace "statements" property in StatementList struct with ""statement_list_items" terminology - replace "statements" property in StatementList struct with "statement_list_items" Oct 10, 2020
@Lan2u
Copy link

Lan2u commented Oct 12, 2020

Could u send a spec link?

@Razican
Copy link
Member

Razican commented Oct 12, 2020

In the case we change this, I would just call it items.

@croraf
Copy link
Contributor Author

croraf commented Oct 13, 2020

https://tc39.es/ecma262/#prod-StatementList

@jasonwilliams
Copy link
Member

I’m ok with just items

@AnnikaCodes
Copy link
Contributor

I'm going to work on this - do we want to change the statements() method in the impl or just the property?

Personally I think that it should be changed, since it could contain declarations.

@AnnikaCodes AnnikaCodes mentioned this issue Dec 31, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

StatementList: Rename statements to items AnnikaCodes/boa
5 participants
@Razican @jasonwilliams @Lan2u @croraf @AnnikaCodes