-
-
Notifications
You must be signed in to change notification settings - Fork 402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Object.prototype.hasOwnProperty()
#1004
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix panic when argument is not supplied. - Fix panic when `this` is not a object. - Fix Symbol property handling.
HalidOdat
added
bug
Something isn't working
builtins
PRs and Issues related to builtins/intrinsics
labels
Dec 29, 2020
Test262 conformance changes:
|
Codecov Report
@@ Coverage Diff @@
## master #1004 +/- ##
=======================================
Coverage 59.83% 59.84%
=======================================
Files 167 167
Lines 11018 11018
=======================================
+ Hits 6593 6594 +1
+ Misses 4425 4424 -1
Continue to review full report at Codecov.
|
Benchmark for d51e48eClick to view benchmark
|
RageKnify
approved these changes
Dec 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It changes the following:
this
is not a object.