Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Object.prototype.hasOwnProperty() #1004

Merged
merged 1 commit into from
Dec 31, 2020

Conversation

HalidOdat
Copy link
Member

It changes the following:

  • Fix panic when argument is not supplied.
  • Fix panic when this is not a object.
  • Fix Symbol property handling.

 - Fix panic when argument is not supplied.
 - Fix panic when `this` is not a object.
 - Fix Symbol property handling.
@HalidOdat HalidOdat added bug Something isn't working builtins PRs and Issues related to builtins/intrinsics labels Dec 29, 2020
@HalidOdat HalidOdat added this to the v0.11.0 milestone Dec 29, 2020
@github-actions
Copy link

Test262 conformance changes:

Test result master count PR count difference
Total 78,493 78,493 0
Passed 19,787 19,799 +12
Ignored 15,585 15,585 0
Failed 43,121 43,109 -12
Panics 396 390 -6
Conformance 25.21 25.22 +0.02%

@codecov
Copy link

codecov bot commented Dec 29, 2020

Codecov Report

Merging #1004 (e449546) into master (6f3641d) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1004   +/-   ##
=======================================
  Coverage   59.83%   59.84%           
=======================================
  Files         167      167           
  Lines       11018    11018           
=======================================
+ Hits         6593     6594    +1     
+ Misses       4425     4424    -1     
Impacted Files Coverage Δ
boa/src/builtins/object/mod.rs 67.68% <100.00%> (+0.01%) ⬆️
boa/src/object/gcobject.rs 65.60% <100.00%> (+0.36%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6f3641d...e449546. Read the comment docs.

@github-actions
Copy link

Benchmark for d51e48e

Click to view benchmark
Test PR Benchmark Master Benchmark %
Arithmetic operations (Execution) 389.4±15.59ns 384.7±10.51ns +1.22%
Arithmetic operations (Full) 269.0±10.16µs 276.6±7.50µs -2.75%
Array access (Execution) 9.3±0.32µs 9.3±0.43µs 0.00%
Array access (Full) 296.4±9.83µs 301.0±11.27µs -1.53%
Array creation (Execution) 3.1±0.09ms 2.9±0.12ms +6.90%
Array creation (Full) 3.2±0.10ms 3.1±0.09ms +3.23%
Array pop (Execution) 1140.2±30.42µs 1073.1±40.21µs +6.25%
Array pop (Full) 1584.9±52.29µs 1548.9±45.34µs +2.32%
Boolean Object Access (Execution) 5.3±0.18µs 5.4±0.27µs -1.85%
Boolean Object Access (Full) 283.3±8.22µs 285.5±9.43µs -0.77%
Clean js (Execution) 791.6±31.13µs 787.7±21.40µs +0.50%
Clean js (Full) 1126.4±40.11µs 1119.8±40.09µs +0.59%
Clean js (Parser) 39.5±1.62µs 38.3±1.74µs +3.13%
Create Realm 506.0±14.85ns 508.6±18.03ns -0.51%
Dynamic Object Property Access (Execution) 6.5±0.20µs 6.4±0.30µs +1.56%
Dynamic Object Property Access (Full) 295.2±12.48µs 305.8±7.35µs -3.47%
Expression (Parser) 6.9±0.17µs 7.0±0.19µs -1.43%
Fibonacci (Execution) 1011.1±30.70µs 1006.8±33.35µs +0.43%
Fibonacci (Full) 1343.3±41.52µs 1327.7±43.60µs +1.17%
For loop (Execution) 26.2±1.65µs 26.0±1.00µs +0.77%
For loop (Full) 318.4±9.95µs 320.1±12.93µs -0.53%
For loop (Parser) 19.6±0.93µs 18.7±0.71µs +4.81%
Goal Symbols (Parser) 12.9±0.52µs 12.5±0.58µs +3.20%
Hello World (Parser) 3.3±0.13µs 3.4±0.11µs -2.94%
Long file (Parser) 829.3±28.73ns 808.3±41.93ns +2.60%
Mini js (Execution) 718.8±27.65µs 721.8±23.29µs -0.42%
Mini js (Full) 1016.9±55.06µs 1001.7±31.50µs +1.52%
Mini js (Parser) 34.7±1.18µs 33.6±1.06µs +3.27%
Number Object Access (Execution) 4.2±0.12µs 4.2±0.13µs 0.00%
Number Object Access (Full) 284.3±11.23µs 282.5±8.97µs +0.64%
Object Creation (Execution) 5.7±0.20µs 5.5±0.19µs +3.64%
Object Creation (Full) 291.2±8.37µs 295.7±9.45µs -1.52%
RegExp (Execution) 10.2±0.52µs 10.2±0.28µs 0.00%
RegExp (Full) 303.6±12.05µs 302.2±8.94µs +0.46%
RegExp Literal (Execution) 11.4±0.40µs 11.9±0.39µs -4.20%
RegExp Literal (Full) 299.8±10.90µs 302.4±19.93µs -0.86%
RegExp Literal Creation (Execution) 10.4±0.29µs 10.2±0.34µs +1.96%
RegExp Literal Creation (Full) 290.7±12.02µs 296.8±9.93µs -2.06%
Static Object Property Access (Execution) 6.0±0.24µs 5.8±0.22µs +3.45%
Static Object Property Access (Full) 295.0±11.54µs 291.3±11.64µs +1.27%
String Object Access (Execution) 7.8±0.30µs 7.7±0.32µs +1.30%
String Object Access (Full) 288.4±10.83µs 290.9±16.19µs -0.86%
String comparison (Execution) 7.4±0.31µs 7.5±0.39µs -1.33%
String comparison (Full) 293.8±13.71µs 290.7±8.95µs +1.07%
String concatenation (Execution) 6.0±0.18µs 6.1±0.21µs -1.64%
String concatenation (Full) 283.9±7.33µs 283.2±9.66µs +0.25%
String copy (Execution) 4.7±0.16µs 4.7±0.15µs 0.00%
String copy (Full) 283.1±14.18µs 277.7±7.55µs +1.94%
Symbols (Execution) 4.1±0.15µs 4.1±0.12µs 0.00%
Symbols (Full) 275.8±11.18µs 275.4±13.58µs +0.15%

@HalidOdat HalidOdat merged commit 724930d into master Dec 31, 2020
@HalidOdat HalidOdat deleted the fix/object-prototype-hasownproperty branch December 31, 2020 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working builtins PRs and Issues related to builtins/intrinsics
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants