Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement early errors for non-assignable nodes in assignment #1019

Merged
merged 1 commit into from
Jan 1, 2021
Merged

Implement early errors for non-assignable nodes in assignment #1019

merged 1 commit into from
Jan 1, 2021

Conversation

tofpie
Copy link
Contributor

@tofpie tofpie commented Jan 1, 2021

This Pull Request implements early error for non-assignable nodes in assignment.

It changes the following:

  • is_assignable function in Assignment parsing

@codecov
Copy link

codecov bot commented Jan 1, 2021

Codecov Report

Merging #1019 (e5e5e4a) into master (4625c1a) will decrease coverage by 0.00%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1019      +/-   ##
==========================================
- Coverage   60.10%   60.10%   -0.01%     
==========================================
  Files         167      167              
  Lines       11142    11143       +1     
==========================================
  Hits         6697     6697              
- Misses       4445     4446       +1     
Impacted Files Coverage Δ
boa/src/syntax/parser/expression/assignment/mod.rs 50.00% <50.00%> (-0.59%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4625c1a...e5e5e4a. Read the comment docs.

@Razican Razican added the enhancement New feature or request label Jan 1, 2021
@Razican Razican added this to the v0.11.0 milestone Jan 1, 2021
@Razican
Copy link
Member

Razican commented Jan 1, 2021

Test262 conformance changes:

Test result master count PR count difference
Total 78,493 78,493 0
Passed 20,882 21,107 +225
Ignored 15,585 15,585 0
Failed 42,026 41,801 -225
Panics 388 388 0
Conformance 26.60 26.89 +0.29%

Copy link
Member

@Razican Razican left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looking good!

@Razican Razican merged commit e11abfb into boa-dev:master Jan 1, 2021
@tofpie tofpie deleted the fix-target-type-assignment branch January 1, 2021 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants