Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement support of Symbol.toPrimitive #1020

Merged
merged 4 commits into from
Jan 1, 2021
Merged

Implement support of Symbol.toPrimitive #1020

merged 4 commits into from
Jan 1, 2021

Conversation

tofpie
Copy link
Contributor

@tofpie tofpie commented Jan 1, 2021

This Pull Request implements the use of Symbol.toPrimitive in the to_primitive method of Value.

It changes the following:

  • to_primitive method of Value to support Symbol.toPrimitive

@codecov
Copy link

codecov bot commented Jan 1, 2021

Codecov Report

Merging #1020 (219e1ae) into master (3b83767) will increase coverage by 0.01%.
The diff coverage is 60.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1020      +/-   ##
==========================================
+ Coverage   60.10%   60.12%   +0.01%     
==========================================
  Files         167      167              
  Lines       11142    11152      +10     
==========================================
+ Hits         6697     6705       +8     
- Misses       4445     4447       +2     
Impacted Files Coverage Δ
boa/src/value/mod.rs 73.95% <60.00%> (-0.38%) ⬇️
boa/src/object/gcobject.rs 66.55% <0.00%> (+0.68%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3b83767...f146a30. Read the comment docs.

@Razican Razican added builtins PRs and Issues related to builtins/intrinsics enhancement New feature or request labels Jan 1, 2021
@Razican Razican added this to the v0.11.0 milestone Jan 1, 2021
@Razican
Copy link
Member

Razican commented Jan 1, 2021

The conformance improvement looks nice :)

Test262 conformance changes:

Test result master count PR count difference
Total 78,493 78,493 0
Passed 20,882 20,942 +60
Ignored 15,585 15,585 0
Failed 42,026 41,966 -60
Panics 388 388 0
Conformance 26.60 26.68 +0.08%

Copy link
Member

@Razican Razican left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

boa/src/value/mod.rs Outdated Show resolved Hide resolved
boa/src/value/mod.rs Outdated Show resolved Hide resolved
boa/src/value/tests.rs Outdated Show resolved Hide resolved
Co-authored-by: João Borges <rageknify@gmail.com>
@Razican Razican requested a review from HalidOdat January 1, 2021 16:04
@HalidOdat HalidOdat merged commit d6a5947 into boa-dev:master Jan 1, 2021
@tofpie tofpie deleted the to-primitive branch January 1, 2021 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
builtins PRs and Issues related to builtins/intrinsics enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants