-
-
Notifications
You must be signed in to change notification settings - Fork 408
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix delete when the property is not configurable #1024
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1024 +/- ##
==========================================
+ Coverage 60.26% 60.31% +0.05%
==========================================
Files 169 169
Lines 11412 11418 +6
==========================================
+ Hits 6877 6887 +10
+ Misses 4535 4531 -4
Continue to review full report at Codecov.
|
Nice conformance improvement! Test262 conformance changes:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks!
Co-authored-by: Halid Odat <halidodat@gmail.com>
This Pull Request fixes an issue with
delete
when the property to delete is not configurable. In this case,delete
should not remove the property from the object, and it should returnfalse
.It changes the following:
delete
operator