Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed some panics #1029

Merged
merged 6 commits into from
Jan 3, 2021
Merged

Fixed some panics #1029

merged 6 commits into from
Jan 3, 2021

Conversation

Razican
Copy link
Member

@Razican Razican commented Jan 2, 2021

This Pull Request is related to #817.

It changes the following:

  • Object.setPrototypeOf and Object.getPrototypeOf are spec compliant

@Razican Razican added bug Something isn't working builtins PRs and Issues related to builtins/intrinsics labels Jan 2, 2021
@Razican Razican added this to the v0.11.0 milestone Jan 2, 2021
@github-actions
Copy link

github-actions bot commented Jan 2, 2021

Test262 conformance changes:

Test result master count PR count difference
Total 78,493 78,493 0
Passed 23,989 24,005 +16
Ignored 15,585 15,585 0
Failed 38,919 38,903 -16
Panics 100 90 -10
Conformance 30.56 30.58 +0.02%

@codecov
Copy link

codecov bot commented Jan 2, 2021

Codecov Report

Merging #1029 (4fb28db) into master (1052ccd) will decrease coverage by 0.10%.
The diff coverage is 29.03%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1029      +/-   ##
==========================================
- Coverage   58.72%   58.61%   -0.11%     
==========================================
  Files         172      172              
  Lines       11728    11763      +35     
==========================================
+ Hits         6887     6895       +8     
- Misses       4841     4868      +27     
Impacted Files Coverage Δ
boa/src/builtins/object/mod.rs 62.29% <16.66%> (-5.57%) ⬇️
boa/src/object/mod.rs 51.36% <60.00%> (-0.15%) ⬇️
boa/src/object/gcobject.rs 67.58% <100.00%> (ø)
boa/src/value/display.rs 85.00% <100.00%> (ø)
boa/src/builtins/regexp/mod.rs 67.25% <0.00%> (-2.88%) ⬇️
boa/src/object/internal_methods.rs 62.93% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1052ccd...4fb28db. Read the comment docs.

@github-actions
Copy link

github-actions bot commented Jan 2, 2021

Benchmark for b111fca

Click to view benchmark
Test PR Benchmark Master Benchmark %
Arithmetic operations (Execution) 362.0±1.73ns 361.6±2.18ns +0.11%
Arithmetic operations (Full) 237.3±1.19µs 235.8±1.69µs +0.64%
Array access (Execution) 7.7±0.03µs 7.7±0.03µs 0.00%
Array access (Full) 257.3±0.87µs 256.4±1.59µs +0.35%
Array creation (Execution) 3.0±0.01ms 2.9±0.01ms +3.45%
Array creation (Full) 3.2±0.01ms 3.2±0.02ms 0.00%
Array pop (Execution) 1109.4±7.56µs 1105.7±5.82µs +0.33%
Array pop (Full) 1559.1±5.50µs 1531.8±3.73µs +1.78%
Boolean Object Access (Execution) 4.9±0.01µs 4.9±0.05µs 0.00%
Boolean Object Access (Full) 248.4±1.68µs 248.2±2.27µs +0.08%
Clean js (Execution) 748.6±4.10µs 749.0±4.64µs -0.05%
Clean js (Full) 1043.2±12.18µs 1035.8±16.00µs +0.71%
Clean js (Parser) 34.7±0.17µs 34.8±0.13µs -0.29%
Create Realm 486.9±1.05ns 490.7±4.67ns -0.77%
Dynamic Object Property Access (Execution) 4.9±0.05µs 4.9±0.02µs 0.00%
Dynamic Object Property Access (Full) 252.7±0.93µs 254.6±3.61µs -0.75%
Expression (Parser) 6.8±0.08µs 6.8±0.03µs 0.00%
Fibonacci (Execution) 849.4±5.27µs 863.6±2.10µs -1.64%
Fibonacci (Full) 1147.4±5.69µs 1127.1±8.04µs +1.80%
For loop (Execution) 22.9±0.18µs 23.0±0.14µs -0.43%
For loop (Full) 277.5±1.77µs 275.1±4.01µs +0.87%
For loop (Parser) 17.3±0.06µs 17.3±0.12µs 0.00%
Goal Symbols (Parser) 11.6±0.08µs 11.6±0.09µs 0.00%
Hello World (Parser) 3.1±0.02µs 3.1±0.02µs 0.00%
Long file (Parser) 794.8±3.31ns 807.8±2.60ns -1.61%
Mini js (Execution) 680.8±4.52µs 672.7±6.87µs +1.20%
Mini js (Full) 950.9±5.53µs 949.8±5.26µs +0.12%
Mini js (Parser) 30.7±0.08µs 30.7±0.18µs 0.00%
Number Object Access (Execution) 3.8±0.03µs 3.8±0.02µs 0.00%
Number Object Access (Full) 247.3±0.86µs 246.6±1.92µs +0.28%
Object Creation (Execution) 4.2±0.03µs 4.2±0.02µs 0.00%
Object Creation (Full) 248.0±1.03µs 250.2±0.56µs -0.88%
RegExp (Execution) 9.4±0.08µs 9.4±0.07µs 0.00%
RegExp (Full) 262.2±1.77µs 259.6±0.96µs +1.00%
RegExp Literal (Execution) 10.7±0.08µs 10.7±0.07µs 0.00%
RegExp Literal (Full) 259.4±1.38µs 257.8±1.22µs +0.62%
RegExp Literal Creation (Execution) 9.4±0.05µs 9.4±0.04µs 0.00%
RegExp Literal Creation (Full) 256.2±1.18µs 252.0±1.40µs +1.67%
Static Object Property Access (Execution) 4.5±0.02µs 4.4±0.02µs +2.27%
Static Object Property Access (Full) 254.0±8.36µs 251.7±1.16µs +0.91%
String Object Access (Execution) 6.9±0.04µs 6.9±0.04µs 0.00%
String Object Access (Full) 256.7±2.42µs 252.8±2.08µs +1.54%
String comparison (Execution) 6.2±0.04µs 6.2±0.05µs 0.00%
String comparison (Full) 255.9±1.46µs 252.9±0.70µs +1.19%
String concatenation (Execution) 4.9±0.02µs 4.9±0.03µs 0.00%
String concatenation (Full) 249.4±1.96µs 249.2±1.50µs +0.08%
String copy (Execution) 3.7±0.03µs 3.6±0.02µs +2.78%
String copy (Full) 242.3±1.70µs 240.9±1.83µs +0.58%
Symbols (Execution) 3.1±0.07µs 3.0±0.01µs +3.33%
Symbols (Full) 238.7±0.92µs 238.0±0.93µs +0.29%

@github-actions
Copy link

github-actions bot commented Jan 2, 2021

Benchmark for 3ff00d4

Click to view benchmark
Test PR Benchmark Master Benchmark %
Arithmetic operations (Execution) 303.4±0.20ns 302.4±0.24ns +0.33%
Arithmetic operations (Full) 197.0±0.19µs 198.1±0.25µs -0.56%
Array access (Execution) 6.4±0.02µs 6.4±0.02µs 0.00%
Array access (Full) 216.9±0.25µs 217.5±0.22µs -0.28%
Array creation (Execution) 2.5±0.00ms 2.4±0.00ms +4.17%
Array creation (Full) 2.7±0.00ms 2.6±0.00ms +3.85%
Array pop (Execution) 926.4±1.59µs 923.3±1.70µs +0.34%
Array pop (Full) 1295.6±1.90µs 1278.7±1.84µs +1.32%
Boolean Object Access (Execution) 4.1±0.01µs 4.2±0.01µs -2.38%
Boolean Object Access (Full) 209.2±0.40µs 208.8±0.62µs +0.19%
Clean js (Execution) 627.8±3.45µs 629.0±13.80µs -0.19%
Clean js (Full) 867.4±5.24µs 870.1±6.11µs -0.31%
Clean js (Parser) 30.5±0.02µs 30.7±0.08µs -0.65%
Create Realm 405.3±0.27ns 413.9±3.16ns -2.08%
Dynamic Object Property Access (Execution) 4.2±0.01µs 4.1±0.02µs +2.44%
Dynamic Object Property Access (Full) 210.3±0.46µs 210.2±0.64µs +0.05%
Expression (Parser) 5.7±0.01µs 5.7±0.00µs 0.00%
Fibonacci (Execution) 718.7±0.90µs 715.5±0.75µs +0.45%
Fibonacci (Full) 965.6±1.34µs 952.9±1.27µs +1.33%
For loop (Execution) 19.3±0.05µs 19.3±0.05µs 0.00%
For loop (Full) 230.2±0.32µs 229.6±0.59µs +0.26%
For loop (Parser) 15.1±0.02µs 15.1±0.02µs 0.00%
Goal Symbols (Parser) 10.1±0.01µs 10.1±0.02µs 0.00%
Hello World (Parser) 2.7±0.00µs 2.7±0.00µs 0.00%
Long file (Parser) 689.8±0.51ns 695.7±0.25ns -0.85%
Mini js (Execution) 568.2±2.86µs 564.8±6.80µs +0.60%
Mini js (Full) 795.4±3.04µs 796.6±2.48µs -0.15%
Mini js (Parser) 27.1±0.03µs 27.0±0.03µs +0.37%
Number Object Access (Execution) 3.2±0.00µs 3.3±0.00µs -3.03%
Number Object Access (Full) 207.0±0.34µs 208.2±0.48µs -0.58%
Object Creation (Execution) 3.5±0.01µs 3.5±0.01µs 0.00%
Object Creation (Full) 205.9±0.21µs 208.1±0.41µs -1.06%
RegExp (Execution) 7.8±0.11µs 7.8±0.03µs 0.00%
RegExp (Full) 217.8±0.49µs 221.1±0.74µs -1.49%
RegExp Literal (Execution) 8.9±0.02µs 9.0±0.03µs -1.11%
RegExp Literal (Full) 214.9±0.47µs 215.9±0.30µs -0.46%
RegExp Literal Creation (Execution) 7.7±0.02µs 7.9±0.03µs -2.53%
RegExp Literal Creation (Full) 211.5±0.57µs 211.0±0.34µs +0.24%
Static Object Property Access (Execution) 3.8±0.01µs 3.7±0.01µs +2.70%
Static Object Property Access (Full) 207.3±0.22µs 207.6±0.43µs -0.14%
String Object Access (Execution) 5.8±0.05µs 5.7±0.01µs +1.75%
String Object Access (Full) 211.5±0.41µs 213.9±0.20µs -1.12%
String comparison (Execution) 5.3±0.02µs 5.2±0.02µs +1.92%
String comparison (Full) 210.4±0.20µs 211.4±0.30µs -0.47%
String concatenation (Execution) 4.3±0.01µs 4.1±0.01µs +4.88%
String concatenation (Full) 204.9±0.26µs 210.2±0.38µs -2.52%
String copy (Execution) 3.0±0.01µs 3.0±0.01µs 0.00%
String copy (Full) 201.8±0.26µs 202.1±0.28µs -0.15%
Symbols (Execution) 2.6±0.00µs 2.5±0.01µs +4.00%
Symbols (Full) 198.0±0.30µs 198.4±0.29µs -0.20%

@github-actions
Copy link

github-actions bot commented Jan 2, 2021

Benchmark for 4fc3eea

Click to view benchmark
Test PR Benchmark Master Benchmark %
Arithmetic operations (Execution) 303.4±0.23ns 302.2±0.26ns +0.40%
Arithmetic operations (Full) 199.5±0.62µs 197.5±0.23µs +1.01%
Array access (Execution) 6.5±0.03µs 6.5±0.02µs 0.00%
Array access (Full) 216.8±0.42µs 218.5±0.32µs -0.78%
Array creation (Execution) 2.5±0.00ms 2.4±0.01ms +4.17%
Array creation (Full) 2.7±0.00ms 2.6±0.00ms +3.85%
Array pop (Execution) 924.1±1.32µs 919.2±4.02µs +0.53%
Array pop (Full) 1299.4±2.17µs 1285.2±1.68µs +1.10%
Boolean Object Access (Execution) 4.2±0.02µs 4.1±0.01µs +2.44%
Boolean Object Access (Full) 213.1±0.32µs 208.3±0.23µs +2.30%
Clean js (Execution) 625.0±2.74µs 624.7±3.80µs +0.05%
Clean js (Full) 873.6±10.64µs 870.4±4.19µs +0.37%
Clean js (Parser) 30.8±0.05µs 30.8±0.04µs 0.00%
Create Realm 405.8±0.31ns 429.5±0.26ns -5.52%
Dynamic Object Property Access (Execution) 4.1±0.02µs 4.1±0.02µs 0.00%
Dynamic Object Property Access (Full) 212.4±0.28µs 210.4±0.36µs +0.95%
Expression (Parser) 5.7±0.01µs 5.8±0.01µs -1.72%
Fibonacci (Execution) 726.1±9.80µs 726.6±0.92µs -0.07%
Fibonacci (Full) 969.3±0.95µs 959.3±1.12µs +1.04%
For loop (Execution) 19.2±0.04µs 19.3±0.05µs -0.52%
For loop (Full) 231.7±0.31µs 231.8±0.40µs -0.04%
For loop (Parser) 15.1±0.02µs 15.1±0.03µs 0.00%
Goal Symbols (Parser) 10.1±0.03µs 10.2±0.02µs -0.98%
Hello World (Parser) 2.6±0.00µs 2.7±0.02µs -3.70%
Long file (Parser) 692.0±0.51ns 688.8±5.12ns +0.46%
Mini js (Execution) 567.7±3.29µs 567.9±3.01µs -0.04%
Mini js (Full) 798.7±2.82µs 798.0±2.35µs +0.09%
Mini js (Parser) 27.3±0.04µs 27.2±0.04µs +0.37%
Number Object Access (Execution) 3.2±0.00µs 3.2±0.00µs 0.00%
Number Object Access (Full) 209.3±0.27µs 205.4±0.19µs +1.90%
Object Creation (Execution) 3.5±0.01µs 3.5±0.01µs 0.00%
Object Creation (Full) 209.2±0.32µs 209.9±0.32µs -0.33%
RegExp (Execution) 7.8±0.04µs 7.9±0.03µs -1.27%
RegExp (Full) 221.1±0.32µs 217.4±0.60µs +1.70%
RegExp Literal (Execution) 8.9±0.02µs 9.0±0.02µs -1.11%
RegExp Literal (Full) 216.9±3.62µs 215.6±0.29µs +0.60%
RegExp Literal Creation (Execution) 7.8±0.02µs 7.9±0.03µs -1.27%
RegExp Literal Creation (Full) 211.2±0.60µs 211.0±0.32µs +0.09%
Static Object Property Access (Execution) 3.7±0.01µs 3.7±0.01µs 0.00%
Static Object Property Access (Full) 209.6±0.41µs 208.0±0.29µs +0.77%
String Object Access (Execution) 6.0±0.01µs 5.7±0.03µs +5.26%
String Object Access (Full) 213.3±0.50µs 211.5±0.70µs +0.85%
String comparison (Execution) 5.3±0.01µs 5.1±0.01µs +3.92%
String comparison (Full) 212.4±0.47µs 211.5±0.30µs +0.43%
String concatenation (Execution) 4.2±0.01µs 4.1±0.01µs +2.44%
String concatenation (Full) 209.3±0.21µs 206.5±0.51µs +1.36%
String copy (Execution) 3.1±0.03µs 3.0±0.00µs +3.33%
String copy (Full) 203.9±0.43µs 201.8±0.32µs +1.04%
Symbols (Execution) 2.5±0.01µs 2.6±0.00µs -3.85%
Symbols (Full) 199.2±0.52µs 199.3±0.77µs -0.05%

@github-actions
Copy link

github-actions bot commented Jan 3, 2021

Benchmark for b3f8f6d

Click to view benchmark
Test PR Benchmark Master Benchmark %
Arithmetic operations (Execution) 316.5±19.76ns 356.3±17.10ns -11.17%
Arithmetic operations (Full) 217.0±15.15µs 212.4±15.22µs +2.17%
Array access (Execution) 6.7±0.48µs 6.8±0.54µs -1.47%
Array access (Full) 239.4±16.39µs 235.9±13.91µs +1.48%
Array creation (Execution) 2.6±0.16ms 2.6±0.16ms 0.00%
Array creation (Full) 3.1±0.17ms 2.9±0.17ms +6.90%
Array pop (Execution) 989.8±63.94µs 969.2±53.72µs +2.13%
Array pop (Full) 1440.2±178.10µs 1414.0±88.24µs +1.85%
Boolean Object Access (Execution) 4.4±0.34µs 4.3±0.31µs +2.33%
Boolean Object Access (Full) 227.2±18.35µs 224.1±15.71µs +1.38%
Clean js (Execution) 721.6±53.26µs 678.3±50.99µs +6.38%
Clean js (Full) 938.5±62.12µs 945.4±68.33µs -0.73%
Clean js (Parser) 31.5±2.39µs 32.0±1.98µs -1.56%
Create Realm 432.2±30.79ns 442.5±36.24ns -2.33%
Dynamic Object Property Access (Execution) 4.7±0.42µs 4.5±0.27µs +4.44%
Dynamic Object Property Access (Full) 234.8±12.54µs 222.1±17.21µs +5.72%
Expression (Parser) 6.4±0.47µs 6.2±0.48µs +3.23%
Fibonacci (Execution) 784.8±51.75µs 802.7±44.31µs -2.23%
Fibonacci (Full) 994.8±65.85µs 1041.4±63.77µs -4.47%
For loop (Execution) 21.1±1.95µs 21.4±1.28µs -1.40%
For loop (Full) 251.1±21.69µs 254.4±14.29µs -1.30%
For loop (Parser) 15.5±1.24µs 15.3±1.10µs +1.31%
Goal Symbols (Parser) 11.2±0.74µs 10.3±0.77µs +8.74%
Hello World (Parser) 2.8±0.20µs 2.9±0.20µs -3.45%
Long file (Parser) 730.0±45.88ns 736.7±59.58ns -0.91%
Mini js (Execution) 656.9±67.80µs 597.6±38.98µs +9.92%
Mini js (Full) 882.2±63.78µs 840.3±54.23µs +4.99%
Mini js (Parser) 28.1±1.69µs 27.8±1.93µs +1.08%
Number Object Access (Execution) 3.4±0.28µs 3.5±0.25µs -2.86%
Number Object Access (Full) 220.9±15.50µs 218.9±16.96µs +0.91%
Object Creation (Execution) 3.8±0.25µs 3.9±0.32µs -2.56%
Object Creation (Full) 225.7±15.20µs 223.1±15.65µs +1.17%
RegExp (Execution) 8.5±0.72µs 8.9±0.65µs -4.49%
RegExp (Full) 237.3±16.41µs 233.9±17.62µs +1.45%
RegExp Literal (Execution) 9.3±0.83µs 9.2±0.66µs +1.09%
RegExp Literal (Full) 227.2±17.88µs 237.1±18.76µs -4.18%
RegExp Literal Creation (Execution) 9.0±0.54µs 8.1±0.52µs +11.11%
RegExp Literal Creation (Full) 230.7±18.73µs 227.4±16.29µs +1.45%
Static Object Property Access (Execution) 4.1±0.31µs 4.2±0.33µs -2.38%
Static Object Property Access (Full) 222.2±14.75µs 224.7±14.98µs -1.11%
String Object Access (Execution) 6.6±0.39µs 6.2±0.48µs +6.45%
String Object Access (Full) 217.3±11.56µs 231.6±25.70µs -6.17%
String comparison (Execution) 5.5±0.35µs 5.8±0.43µs -5.17%
String comparison (Full) 228.8±17.24µs 235.5±14.19µs -2.85%
String concatenation (Execution) 4.4±0.35µs 4.3±0.26µs +2.33%
String concatenation (Full) 227.3±14.14µs 218.3±18.21µs +4.12%
String copy (Execution) 3.3±0.23µs 3.3±0.23µs 0.00%
String copy (Full) 221.1±17.53µs 210.5±14.28µs +5.04%
Symbols (Execution) 2.8±0.19µs 2.7±0.17µs +3.70%
Symbols (Full) 227.7±15.79µs 210.2±12.21µs +8.33%

@github-actions
Copy link

github-actions bot commented Jan 3, 2021

Benchmark for d3b93cf

Click to view benchmark
Test PR Benchmark Master Benchmark %
Arithmetic operations (Execution) 363.1±0.29ns 376.9±0.79ns -3.66%
Arithmetic operations (Full) 254.3±16.82µs 232.1±2.27µs +9.56%
Array access (Execution) 7.8±0.03µs 7.7±0.03µs +1.30%
Array access (Full) 257.9±1.82µs 256.7±0.71µs +0.47%
Array creation (Execution) 2.9±0.00ms 2.9±0.00ms 0.00%
Array creation (Full) 3.3±0.00ms 3.2±0.10ms +3.13%
Array pop (Execution) 1080.0±9.33µs 1098.6±7.84µs -1.69%
Array pop (Full) 1567.2±13.81µs 1544.9±5.30µs +1.44%
Boolean Object Access (Execution) 5.2±0.70µs 4.9±0.05µs +6.12%
Boolean Object Access (Full) 253.3±0.50µs 246.0±0.32µs +2.97%
Clean js (Execution) 759.2±5.42µs 759.3±4.04µs -0.01%
Clean js (Full) 1049.1±10.90µs 1042.5±10.28µs +0.63%
Clean js (Parser) 35.0±0.03µs 34.9±0.06µs +0.29%
Create Realm 490.3±0.49ns 505.6±39.17ns -3.03%
Dynamic Object Property Access (Execution) 5.0±0.01µs 5.0±0.01µs 0.00%
Dynamic Object Property Access (Full) 256.6±1.09µs 249.7±0.47µs +2.76%
Expression (Parser) 6.9±0.01µs 6.8±0.02µs +1.47%
Fibonacci (Execution) 857.5±0.97µs 860.0±0.62µs -0.29%
Fibonacci (Full) 1151.6±1.37µs 1202.6±52.42µs -4.24%
For loop (Execution) 22.9±0.13µs 23.0±0.08µs -0.43%
For loop (Full) 277.9±0.32µs 273.8±0.64µs +1.50%
For loop (Parser) 17.5±0.04µs 17.4±0.04µs +0.57%
Goal Symbols (Parser) 11.8±0.03µs 11.8±0.28µs 0.00%
Hello World (Parser) 3.2±0.02µs 3.1±0.02µs +3.23%
Long file (Parser) 805.8±0.63ns 798.8±0.72ns +0.88%
Mini js (Execution) 680.8±4.70µs 683.2±3.51µs -0.35%
Mini js (Full) 961.9±3.24µs 955.8±9.49µs +0.64%
Mini js (Parser) 30.9±0.11µs 30.8±0.03µs +0.32%
Number Object Access (Execution) 3.9±0.00µs 3.9±0.01µs 0.00%
Number Object Access (Full) 253.4±9.93µs 242.4±0.84µs +4.54%
Object Creation (Execution) 4.2±0.01µs 4.2±0.01µs 0.00%
Object Creation (Full) 253.2±0.87µs 258.4±7.70µs -2.01%
RegExp (Execution) 9.2±0.02µs 9.4±0.03µs -2.13%
RegExp (Full) 263.7±0.41µs 267.9±7.32µs -1.57%
RegExp Literal (Execution) 10.5±0.05µs 10.6±0.07µs -0.94%
RegExp Literal (Full) 261.3±0.37µs 256.8±0.36µs +1.75%
RegExp Literal Creation (Execution) 9.2±0.07µs 9.3±0.04µs -1.08%
RegExp Literal Creation (Full) 254.5±0.89µs 263.7±23.92µs -3.49%
Static Object Property Access (Execution) 4.5±0.01µs 4.5±0.07µs 0.00%
Static Object Property Access (Full) 255.3±0.46µs 249.0±1.46µs +2.53%
String Object Access (Execution) 6.9±0.04µs 6.8±0.01µs +1.47%
String Object Access (Full) 255.3±0.47µs 254.1±11.30µs +0.47%
String comparison (Execution) 6.2±0.02µs 6.2±0.02µs 0.00%
String comparison (Full) 255.6±2.76µs 249.0±0.67µs +2.65%
String concatenation (Execution) 4.8±0.01µs 5.0±0.01µs -4.00%
String concatenation (Full) 250.6±3.67µs 242.8±0.30µs +3.21%
String copy (Execution) 3.6±0.00µs 3.7±0.03µs -2.70%
String copy (Full) 244.1±2.30µs 237.3±0.31µs +2.87%
Symbols (Execution) 3.1±0.00µs 3.0±0.01µs +3.33%
Symbols (Full) 240.9±0.36µs 245.6±8.10µs -1.91%

@Razican Razican merged commit 5e78ff8 into master Jan 3, 2021
@RageKnify RageKnify deleted the unwrap_panics branch January 3, 2021 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working builtins PRs and Issues related to builtins/intrinsics
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants