Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed some extra regex panics #1031

Merged
merged 1 commit into from
Jan 2, 2021
Merged

Fixed some extra regex panics #1031

merged 1 commit into from
Jan 2, 2021

Conversation

Razican
Copy link
Member

@Razican Razican commented Jan 2, 2021

This Pull Request is related to #817.

It changes the following:

  • Removes some panics from RegExp methods, but it's probably not 100% spec compliant.

@Razican Razican added bug Something isn't working builtins PRs and Issues related to builtins/intrinsics labels Jan 2, 2021
@Razican Razican added this to the v0.11.0 milestone Jan 2, 2021
@github-actions
Copy link

github-actions bot commented Jan 2, 2021

Test262 conformance changes:

Test result master count PR count difference
Total 78,493 78,493 0
Passed 23,804 23,849 +45
Ignored 15,585 15,585 0
Failed 39,104 39,059 -45
Panics 363 316 -47
Conformance 30.33 30.38 +0.06%

@codecov
Copy link

codecov bot commented Jan 2, 2021

Codecov Report

Merging #1031 (4b8e5b4) into master (1052ccd) will decrease coverage by 0.03%.
The diff coverage is 63.23%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1031      +/-   ##
==========================================
- Coverage   58.72%   58.68%   -0.04%     
==========================================
  Files         172      172              
  Lines       11728    11741      +13     
==========================================
+ Hits         6887     6890       +3     
- Misses       4841     4851      +10     
Impacted Files Coverage Δ
boa/src/object/internal_methods.rs 62.93% <ø> (ø)
boa/src/builtins/regexp/mod.rs 66.46% <63.23%> (-3.67%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1052ccd...4b8e5b4. Read the comment docs.

@github-actions
Copy link

github-actions bot commented Jan 2, 2021

Benchmark for 19f84d4

Click to view benchmark
Test PR Benchmark Master Benchmark %
Arithmetic operations (Execution) 320.7±0.17ns 302.3±0.18ns +6.09%
Arithmetic operations (Full) 194.4±1.35µs 196.5±0.19µs -1.07%
Array access (Execution) 6.4±0.03µs 6.5±0.08µs -1.54%
Array access (Full) 211.8±0.27µs 214.8±0.30µs -1.40%
Array creation (Execution) 2.4±0.00ms 2.4±0.00ms 0.00%
Array creation (Full) 2.7±0.00ms 2.6±0.00ms +3.85%
Array pop (Execution) 911.8±2.49µs 919.3±3.37µs -0.82%
Array pop (Full) 1280.5±1.77µs 1275.9±1.88µs +0.36%
Boolean Object Access (Execution) 4.1±0.00µs 4.1±0.01µs 0.00%
Boolean Object Access (Full) 206.2±0.25µs 207.6±0.27µs -0.67%
Clean js (Execution) 624.0±3.05µs 622.1±3.93µs +0.31%
Clean js (Full) 871.5±5.92µs 868.1±7.63µs +0.39%
Clean js (Parser) 30.7±0.05µs 30.7±0.04µs 0.00%
Create Realm 406.1±0.20ns 411.0±3.72ns -1.19%
Dynamic Object Property Access (Execution) 4.1±0.02µs 4.2±0.01µs -2.38%
Dynamic Object Property Access (Full) 207.9±0.37µs 210.0±0.37µs -1.00%
Expression (Parser) 5.8±0.00µs 5.7±0.00µs +1.75%
Fibonacci (Execution) 725.5±0.59µs 720.3±0.80µs +0.72%
Fibonacci (Full) 954.4±0.96µs 953.8±1.09µs +0.06%
For loop (Execution) 19.3±0.16µs 19.3±0.05µs 0.00%
For loop (Full) 227.9±0.73µs 230.2±1.12µs -1.00%
For loop (Parser) 15.2±0.03µs 15.1±0.02µs +0.66%
Goal Symbols (Parser) 10.1±0.02µs 10.1±0.02µs 0.00%
Hello World (Parser) 2.7±0.02µs 2.7±0.00µs 0.00%
Long file (Parser) 692.6±0.32ns 691.5±0.46ns +0.16%
Mini js (Execution) 566.6±3.42µs 564.7±2.94µs +0.34%
Mini js (Full) 794.2±4.48µs 799.4±3.26µs -0.65%
Mini js (Parser) 27.0±0.05µs 27.2±0.02µs -0.74%
Number Object Access (Execution) 3.3±0.01µs 3.2±0.01µs +3.12%
Number Object Access (Full) 201.8±0.38µs 208.2±0.48µs -3.07%
Object Creation (Execution) 3.5±0.01µs 3.5±0.01µs 0.00%
Object Creation (Full) 207.1±0.34µs 207.4±0.36µs -0.14%
RegExp (Execution) 7.7±0.03µs 7.9±0.03µs -2.53%
RegExp (Full) 216.4±0.24µs 217.0±0.45µs -0.28%
RegExp Literal (Execution) 8.9±0.03µs 8.9±0.02µs 0.00%
RegExp Literal (Full) 212.4±0.41µs 216.1±0.59µs -1.71%
RegExp Literal Creation (Execution) 7.7±0.03µs 7.9±0.03µs -2.53%
RegExp Literal Creation (Full) 207.9±0.35µs 209.6±0.27µs -0.81%
Static Object Property Access (Execution) 3.7±0.01µs 3.7±0.01µs 0.00%
Static Object Property Access (Full) 207.4±0.51µs 207.1±0.31µs +0.14%
String Object Access (Execution) 5.7±0.02µs 5.7±0.02µs 0.00%
String Object Access (Full) 209.9±0.21µs 210.9±0.29µs -0.47%
String comparison (Execution) 5.1±0.03µs 5.3±0.02µs -3.77%
String comparison (Full) 207.9±1.03µs 212.0±0.34µs -1.93%
String concatenation (Execution) 4.2±0.01µs 4.1±0.02µs +2.44%
String concatenation (Full) 204.7±5.38µs 208.7±0.48µs -1.92%
String copy (Execution) 3.0±0.01µs 3.1±0.01µs -3.23%
String copy (Full) 198.9±0.39µs 203.3±0.43µs -2.16%
Symbols (Execution) 2.6±0.00µs 2.6±0.00µs 0.00%
Symbols (Full) 195.1±0.25µs 198.2±0.45µs -1.56%

@RageKnify RageKnify merged commit 553ea52 into master Jan 2, 2021
@RageKnify RageKnify deleted the regex_panics branch January 3, 2021 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working builtins PRs and Issues related to builtins/intrinsics
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants