Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Symbol.prototype.description accessor #1222

Merged
merged 2 commits into from
May 8, 2021

Conversation

HalidOdat
Copy link
Member

It changes the following:

  • Implement Symbol.prototype.description accessor

@HalidOdat HalidOdat added enhancement New feature or request builtins PRs and Issues related to builtins/intrinsics labels May 4, 2021
@HalidOdat HalidOdat added this to the v0.12.0 milestone May 4, 2021
@github-actions
Copy link

github-actions bot commented May 4, 2021

Test262 conformance changes:

Test result master count PR count difference
Total 78,497 78,497 0
Passed 25,515 25,523 +8
Ignored 15,587 15,587 0
Failed 37,395 37,387 -8
Panics 13 14 +1
Conformance 32.50 32.51 +0.01%

@github-actions
Copy link

github-actions bot commented May 4, 2021

Benchmark for 7e3c392

Click to view benchmark
Test PR Benchmark Master Benchmark %
Arithmetic operations (Execution) 334.4±11.04ns 328.5±12.03ns +1.80%
Arithmetic operations (Full) 218.5±10.98µs 225.4±8.26µs -3.06%
Array access (Execution) 5.6±0.31µs 5.3±0.29µs +5.66%
Array access (Full) 240.1±12.30µs 249.7±8.83µs -3.84%
Array creation (Execution) 2.6±0.14ms 2.6±0.14ms 0.00%
Array creation (Full) 2.8±0.16ms 2.9±0.10ms -3.45%
Array pop (Execution) 933.9±34.01µs 807.4±37.25µs +15.67%
Array pop (Full) 1237.4±73.43µs 1321.9±46.62µs -6.39%
Boolean Object Access (Execution) 4.9±0.25µs 4.9±0.19µs 0.00%
Boolean Object Access (Full) 235.2±10.99µs 248.6±9.33µs -5.39%
Clean js (Execution) 614.5±28.57µs 608.6±25.90µs +0.97%
Clean js (Full) 844.7±47.55µs 888.3±32.88µs -4.91%
Clean js (Parser) 39.1±2.43µs 37.5±1.95µs +4.27%
Create Realm 400.2±22.21ns 407.2±12.08ns -1.72%
Dynamic Object Property Access (Execution) 4.8±0.12µs 4.3±0.24µs +11.63%
Dynamic Object Property Access (Full) 237.1±12.71µs 249.8±8.05µs -5.08%
Expression (Parser) 6.2±0.39µs 6.3±0.21µs -1.59%
Fibonacci (Execution) 703.8±32.06µs 695.1±35.88µs +1.25%
Fibonacci (Full) 903.4±40.08µs 951.5±34.10µs -5.06%
For loop (Execution) 20.4±0.58µs 19.7±0.74µs +3.55%
For loop (Full) 248.0±12.55µs 267.9±11.43µs -7.43%
For loop (Parser) 18.6±1.12µs 19.0±0.84µs -2.11%
Goal Symbols (Parser) 12.8±0.75µs 12.6±0.71µs +1.59%
Hello World (Parser) 3.5±0.19µs 3.6±0.14µs -2.78%
Long file (Parser) 711.3±31.42ns 697.0±37.35ns +2.05%
Mini js (Execution) 513.8±30.63µs 551.5±21.53µs -6.84%
Mini js (Full) 768.1±39.73µs 818.2±28.39µs -6.12%
Mini js (Parser) 34.1±2.02µs 32.6±1.75µs +4.60%
Number Object Access (Execution) 3.8±0.19µs 4.0±0.13µs -5.00%
Number Object Access (Full) 231.0±13.63µs 239.3±7.99µs -3.47%
Object Creation (Execution) 3.6±0.18µs 3.7±0.21µs -2.70%
Object Creation (Full) 226.0±13.66µs 246.8±9.06µs -8.43%
RegExp (Execution) 8.7±0.48µs 9.3±0.40µs -6.45%
RegExp (Full) 236.7±11.10µs 247.6±9.77µs -4.40%
RegExp Literal (Execution) 10.3±0.58µs 10.5±0.36µs -1.90%
RegExp Literal (Full) 239.3±13.33µs 259.7±10.29µs -7.86%
RegExp Literal Creation (Execution) 9.0±0.45µs 9.5±0.54µs -5.26%
RegExp Literal Creation (Full) 238.6±13.62µs 252.7±9.05µs -5.58%
Static Object Property Access (Execution) 3.9±0.24µs 3.9±0.27µs 0.00%
Static Object Property Access (Full) 229.0±10.70µs 242.4±8.61µs -5.53%
String Object Access (Execution) 6.6±0.33µs 6.8±0.22µs -2.94%
String Object Access (Full) 243.2±14.73µs 250.4±10.39µs -2.88%
String comparison (Execution) 5.7±0.28µs 6.1±0.21µs -6.56%
String comparison (Full) 232.7±12.54µs 244.3±8.70µs -4.75%
String concatenation (Execution) 4.9±0.22µs 4.9±0.17µs 0.00%
String concatenation (Full) 235.9±14.16µs 235.5±8.40µs +0.17%
String copy (Execution) 3.4±0.14µs 3.6±0.11µs -5.56%
String copy (Full) 233.7±16.67µs 233.1±8.53µs +0.26%
Symbols (Execution) 2.9±0.15µs 3.0±0.12µs -3.33%
Symbols (Full) 220.1±12.08µs 225.6±6.86µs -2.44%

Copy link
Member

@RageKnify RageKnify left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confusing that panics were introduced, but might be the ghost 2 that keep showing up in CI.

@github-actions
Copy link

github-actions bot commented May 7, 2021

Benchmark for a5635e4

Click to view benchmark
Test PR Benchmark Master Benchmark %
Arithmetic operations (Execution) 359.3±6.46ns 364.6±7.09ns -1.45%
Arithmetic operations (Full) 241.4±5.80µs 236.7±5.20µs +1.99%
Array access (Execution) 5.9±0.14µs 6.1±0.07µs -3.28%
Array access (Full) 267.4±6.16µs 261.3±6.23µs +2.33%
Array creation (Execution) 2.7±0.07ms 2.8±0.04ms -3.57%
Array creation (Full) 3.1±0.07ms 3.1±0.07ms 0.00%
Array pop (Execution) 880.9±21.77µs 883.2±21.48µs -0.26%
Array pop (Full) 1361.0±33.31µs 1360.9±29.49µs +0.01%
Boolean Object Access (Execution) 5.1±0.12µs 5.1±0.12µs 0.00%
Boolean Object Access (Full) 256.3±6.62µs 257.4±5.12µs -0.43%
Clean js (Execution) 641.4±14.54µs 642.8±15.07µs -0.22%
Clean js (Full) 938.8±21.62µs 941.3±19.18µs -0.27%
Clean js (Parser) 39.4±0.89µs 39.2±1.14µs +0.51%
Create Realm 429.8±7.62ns 429.9±8.96ns -0.02%
Dynamic Object Property Access (Execution) 5.0±0.12µs 4.9±0.10µs +2.04%
Dynamic Object Property Access (Full) 261.6±6.49µs 261.3±7.53µs +0.11%
Expression (Parser) 6.6±0.12µs 6.7±0.16µs -1.49%
Fibonacci (Execution) 771.1±11.86µs 766.2±14.34µs +0.64%
Fibonacci (Full) 1024.3±25.23µs 1019.6±23.79µs +0.46%
For loop (Execution) 22.2±0.37µs 21.5±0.43µs +3.26%
For loop (Full) 276.6±7.27µs 278.7±7.53µs -0.75%
For loop (Parser) 19.1±0.47µs 19.2±0.45µs -0.52%
Goal Symbols (Parser) 13.4±0.33µs 13.4±0.35µs 0.00%
Hello World (Parser) 3.7±0.07µs 3.7±0.08µs 0.00%
Long file (Parser) 752.5±18.12ns 769.7±17.87ns -2.23%
Mini js (Execution) 585.3±19.51µs 579.8±15.79µs +0.95%
Mini js (Full) 866.1±22.87µs 853.1±22.78µs +1.52%
Mini js (Parser) 34.6±0.91µs 35.2±0.52µs -1.70%
Number Object Access (Execution) 4.0±0.09µs 4.0±0.09µs 0.00%
Number Object Access (Full) 255.0±5.85µs 257.2±5.32µs -0.86%
Object Creation (Execution) 4.2±0.11µs 4.2±0.12µs 0.00%
Object Creation (Full) 252.6±8.74µs 257.1±5.50µs -1.75%
RegExp (Execution) 11.3±0.22µs 11.4±0.25µs -0.88%
RegExp (Full) 268.8±6.36µs 268.4±3.09µs +0.15%
RegExp Literal (Execution) 11.4±0.25µs 11.3±0.24µs +0.88%
RegExp Literal (Full) 269.6±5.24µs 277.1±2.44µs -2.71%
RegExp Literal Creation (Execution) 10.2±0.18µs 10.0±0.22µs +2.00%
RegExp Literal Creation (Full) 264.7±6.16µs 263.6±4.28µs +0.42%
Static Object Property Access (Execution) 4.5±0.09µs 4.5±0.09µs 0.00%
Static Object Property Access (Full) 260.7±5.89µs 257.2±4.53µs +1.36%
String Object Access (Execution) 7.2±0.29µs 7.1±0.20µs +1.41%
String Object Access (Full) 261.7±5.23µs 260.5±7.05µs +0.46%
String comparison (Execution) 6.3±0.16µs 6.5±0.17µs -3.08%
String comparison (Full) 260.8±5.52µs 261.1±5.64µs -0.11%
String concatenation (Execution) 5.3±0.16µs 5.2±0.13µs +1.92%
String concatenation (Full) 253.2±5.49µs 255.3±5.25µs -0.82%
String copy (Execution) 3.7±0.11µs 3.8±0.08µs -2.63%
String copy (Full) 247.8±6.52µs 250.6±6.18µs -1.12%
Symbols (Execution) 3.3±0.06µs 3.2±0.08µs +3.12%
Symbols (Full) 239.6±5.11µs 237.2±6.64µs +1.01%

@HalidOdat HalidOdat merged commit 8a70fdc into master May 8, 2021
@HalidOdat HalidOdat deleted the feature/symbol-prototype-description branch May 8, 2021 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
builtins PRs and Issues related to builtins/intrinsics enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants