-
-
Notifications
You must be signed in to change notification settings - Fork 402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Object.assign( target, ...sources )
#1235
Conversation
Object.assign( target, ...source )
Test262 conformance changes:
|
Benchmark for 33dcee8Click to view benchmark
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks fine, but it'd be nice to have the usual doc comment pointing to the spec and to MDN.
The function above it, property_is_enumerable
is also missing it, it'd be nice if you could do that too.
Object.assign( target, ...source )
Object.assign( target, ...sources )
Benchmark for b667a76Click to view benchmark
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there is a potential small bug when the function is called with no arguments, but let me know if it's not the case.
No description provided.