unassigned var is undefined #125
Conversation
|
@pop this is awesome! If you want to add the tests you're best off adding them at the bottom of exec.rs You can do something similar to those on exec.rs |
|
@jasonwilliams Good to know! I added two tests to the bottom of Let me know if you want me to remove the changes to |
|
@pop if you could update the CHANGELOG and revert the test.js changes that would be great |
|
@pop sorry ive merged since so you may need to rebase |
pop
force-pushed
the
bug/unassigned-var-undefined
branch
from
af8e876 to
7aa105d
Compare
pop
force-pushed
the
bug/unassigned-var-undefined
branch
from
7aa105d to
35d2d47
Compare
pop
force-pushed
the
bug/unassigned-var-undefined
branch
from
35d2d47 to
2c44735
Compare
|
@jasonwilliams I think it's ready 😄 Added some CHANGELOG text, removed my tests/js/test.js code and added a comment to that file to help future me, and fixed my tests. |
* Unassigned variables are set to `undefined` not `null` Fixes boa-dev#113 * Rust tests for `var x` and `let x` default to undefined * CHANGELOG for issue boa-dev#113 fix + add tests/js/test.js to gitignore.
* Added create_constructor method * Updated global to use json::create_constructor method * unassigned var is undefined (#125) * Unassigned variables are set to `undefined` not `null` Fixes #113 * Rust tests for `var x` and `let x` default to undefined * CHANGELOG for issue #113 fix + add tests/js/test.js to gitignore. * fixing PR benchmarks (#132) * fixing PR benchmarks * Push after rebase * Updated import order * Formatting
Fixes #113
Just like the original issue claimed, this was a two line fix...
... but I didn't stop there! I don't feel comfortable making a change without tests, so I built out the
tests/js/test.jsfile to (A) include a test for my fix and (B) include some scaffolding for future JS smoke tests.If you think this needs some changes, feel free to ping me or make some commits on my branch. I'd also be willing to remove the testing changes. They don't really "fit" in this pull request and I'd understand if you are philosophically opposed to them.