Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed hypot length bug #1288

Merged
merged 1 commit into from
May 28, 2021
Merged

Fixed hypot length bug #1288

merged 1 commit into from
May 28, 2021

Conversation

moadmmh
Copy link
Contributor

@moadmmh moadmmh commented May 28, 2021

This Pull Request fixes/closes #1269

It changes the following:

  • Math.hypot.length to be 2

@Razican
Copy link
Member

Razican commented May 28, 2021 •
edited
Loading

Test262 conformance changes:

Test result master count PR count difference
Total 78,873 78,873 0
Passed 26,663 26,665 +2
Ignored 15,604 15,604 0
Failed 36,606 36,604 -2
Panics 14 14 0
Conformance 33.80% 33.81% +0.00%

Razican
Razican approved these changes May 28, 2021
View reviewed changes
Copy link
Member

@Razican Razican left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fix!

@Razican Razican added bug Something isn't working builtins PRs and Issues related to builtins/intrinsics labels May 28, 2021
@Razican Razican added this to the v0.12.0 milestone May 28, 2021
@Razican Razican merged commit e577f2a into boa-dev:master May 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Razican Razican Razican approved these changes

Assignees
No one assigned
Labels
bug Something isn't working builtins PRs and Issues related to builtins/intrinsics
Projects
None yet
Milestone
v0.12.0
Development

Successfully merging this pull request may close these issues.

Math.hypot.length should be 2
2 participants
@moadmmh @Razican