Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement symbol.prototype[ @@ToStringTag] #1292

Merged
merged 13 commits into from
May 29, 2021
Merged

Implement symbol.prototype[ @@ToStringTag] #1292

merged 13 commits into from
May 29, 2021

Conversation

moadmmh
Copy link
Contributor

@moadmmh moadmmh commented May 29, 2021

This Pull Request fixes/closes #1231.

It changes the following:

  • implement symbol.prototype[ @@ToStringTag]

Razican
Razican reviewed May 29, 2021
View reviewed changes
Copy link
Member

@Razican Razican left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's looking good! Check my comment :)

boa/src/builtins/symbol/mod.rs Outdated Show resolved Hide resolved
@Razican
Copy link
Member

Razican commented May 29, 2021 •
edited
Loading

Test262 conformance changes:

Test result master count PR count difference
Total 78,873 78,873 0
Passed 26,665 26,667 +2
Ignored 15,604 15,604 0
Failed 36,604 36,602 -2
Panics 14 14 0
Conformance 33.81% 33.81% +0.00%
Fixed tests: 
test/built-ins/Symbol/prototype/Symbol.toStringTag.js [strict mode] (previously Failed)
test/built-ins/Symbol/prototype/Symbol.toStringTag.js (previously Failed)

@Razican Razican added this to the v0.12.0 milestone May 29, 2021
@Razican Razican added builtins PRs and Issues related to builtins/intrinsics enhancement New feature or request labels May 29, 2021
@Razican Razican merged commit c6d5689 into boa-dev:master May 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Razican Razican Razican approved these changes

@RageKnify RageKnify RageKnify approved these changes

@HalidOdat HalidOdat Awaiting requested review from HalidOdat

@0x7D2B 0x7D2B Awaiting requested review from 0x7D2B

@tofpie tofpie Awaiting requested review from tofpie

Assignees
No one assigned
Labels
builtins PRs and Issues related to builtins/intrinsics enhancement New feature or request
Projects
None yet
Milestone
v0.12.0
Development

Successfully merging this pull request may close these issues.

Implement Symbol.prototype[ @@toStringTag ]
3 participants
@moadmmh @Razican @RageKnify