fix VM branch #1302
Merged
fix VM branch #1302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Razican
requested changes
Jun 2, 2021
…tack in future - adds (basic) test for VM
- remove print execution
RageKnify
reviewed
Jun 4, 2021
| @@ -14,6 +14,7 @@ pub trait Executable { | |||
| pub(crate) enum InterpreterState { | |||
| Executing, | |||
| Return, | |||
| Error, | |||
There was a problem hiding this comment.
Maybe we can allow the clippy lint that complains that this variant is never constructed, since it is only constructed with the vm feature on. Or maybe only compile it with the vm feature on?
RageKnify
approved these changes
Jun 5, 2021
Razican
approved these changes
Jun 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The VM branch was failing to build. This uses the latest API changes made on Context.
This PR also introduces a new state to the executor, the
Errorstate. This lets the VM know that an error has happened and immediately stops, leaving the error value on the top of the stack. Going forward this can be used to unwind the stack.As the current path doesn't make use of this arm it should be backwards compatible.