-
-
Notifications
You must be signed in to change notification settings - Fork 400
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix VM branch #1302
fix VM branch #1302
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would add a test that at least builds this branch, to make sure it keeps working.
…tack in future - adds (basic) test for VM
- remove print execution
@@ -14,6 +14,7 @@ pub trait Executable { | |||
pub(crate) enum InterpreterState { | |||
Executing, | |||
Return, | |||
Error, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we can allow the clippy lint that complains that this variant is never constructed, since it is only constructed with the vm
feature on. Or maybe only compile it with the vm
feature on?
The VM branch was failing to build. This uses the latest API changes made on Context.
This PR also introduces a new state to the executor, the
Error
state. This lets the VM know that an error has happened and immediately stops, leaving the error value on the top of the stack. Going forward this can be used to unwind the stack.As the current path doesn't make use of this arm it should be backwards compatible.