Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Array.prototype.sort #1332

Merged
merged 2 commits into from
Aug 22, 2021
Merged

Implement Array.prototype.sort #1332

merged 2 commits into from
Aug 22, 2021

Conversation

jedel1043
Copy link
Member

@jedel1043 jedel1043 commented Jun 17, 2021 •
edited
Loading

This Pull Request checks off a method from #36.

It changes the following:

  • Implements the Array.prototype.sort method
  • Implements tests for Array.prototype.sort

@Razican
Copy link
Member

Razican commented Jun 17, 2021

Test262 conformance changes:

Test result master count PR count difference
Total 78,897 78,897 0
Passed 26,865 26,886 +21
Ignored 15,628 15,628 0
Failed 36,404 36,383 -21
Panics 0 0 0
Conformance 34.05% 34.08% +0.03%
Fixed tests: 
test/language/expressions/property-accessors/S11.2.1_A4_T4.js [strict mode] (previously Failed)
test/language/expressions/property-accessors/S11.2.1_A4_T4.js (previously Failed)
test/built-ins/Object/getOwnPropertyDescriptor/15.2.3.3-4-44.js [strict mode] (previously Failed)
test/built-ins/Object/getOwnPropertyDescriptor/15.2.3.3-4-44.js (previously Failed)
test/built-ins/Array/prototype/sort/S15.4.4.11_A4_T3.js [strict mode] (previously Failed)
test/built-ins/Array/prototype/sort/S15.4.4.11_A4_T3.js (previously Failed)
test/built-ins/Array/prototype/sort/S15.4.4.11_A1.2_T1.js [strict mode] (previously Failed)
test/built-ins/Array/prototype/sort/S15.4.4.11_A1.2_T1.js (previously Failed)
test/built-ins/Array/prototype/sort/S15.4.4.11_A8.js (previously Failed)
test/built-ins/Array/prototype/sort/name.js [strict mode] (previously Failed)
test/built-ins/Array/prototype/sort/name.js (previously Failed)
test/built-ins/Array/prototype/sort/S15.4.4.11_A1.2_T2.js [strict mode] (previously Failed)
test/built-ins/Array/prototype/sort/S15.4.4.11_A1.2_T2.js (previously Failed)
test/built-ins/Array/prototype/sort/prop-desc.js [strict mode] (previously Failed)
test/built-ins/Array/prototype/sort/prop-desc.js (previously Failed)
test/built-ins/Array/prototype/sort/length.js [strict mode] (previously Failed)
test/built-ins/Array/prototype/sort/length.js (previously Failed)
test/built-ins/Array/prototype/sort/S15.4.4.11_A1.1_T1.js [strict mode] (previously Failed)
test/built-ins/Array/prototype/sort/S15.4.4.11_A1.1_T1.js (previously Failed)
test/built-ins/Array/prototype/sort/S15.4.4.11_A1.3_T1.js [strict mode] (previously Failed)
test/built-ins/Array/prototype/sort/S15.4.4.11_A1.3_T1.js (previously Failed)

@Razican Razican added enhancement New feature or request builtins PRs and Issues related to builtins/intrinsics labels Jun 17, 2021
@Razican Razican added this to the v0.13.0 milestone Jun 17, 2021
@jedel1043 jedel1043 marked this pull request as ready for review August 18, 2021 21:07
@jedel1043
Copy link
Member Author

@HalidOdat could you give it a quick review?

@jedel1043
Copy link
Member Author

jedel1043 commented Aug 18, 2021 •
edited
Loading

Test262 conformance changes:

Test result master count PR count difference
Total 78,897 78,897 0
Passed 29,766 29,825 +59
Ignored 15,612 15,612 0
Failed 33,519 33,460 -59
Panics 2 2 0
Conformance 37.73% 37.80% +0.07%
Fixed tests: 
test/built-ins/Object/getOwnPropertyDescriptor/15.2.3.3-4-44.js [strict mode] (previously Failed)
test/built-ins/Object/getOwnPropertyDescriptor/15.2.3.3-4-44.js (previously Failed)
test/built-ins/Array/prototype/sort/S15.4.4.11_A3_T1.js [strict mode] (previously Failed)
test/built-ins/Array/prototype/sort/S15.4.4.11_A3_T1.js (previously Failed)
test/built-ins/Array/prototype/sort/stability-5-elements.js [strict mode] (previously Failed)
test/built-ins/Array/prototype/sort/stability-5-elements.js (previously Failed)
test/built-ins/Array/prototype/sort/S15.4.4.11_A5_T1.js [strict mode] (previously Failed)
test/built-ins/Array/prototype/sort/S15.4.4.11_A5_T1.js (previously Failed)
test/built-ins/Array/prototype/sort/S15.4.4.11_A2.1_T2.js [strict mode] (previously Failed)
test/built-ins/Array/prototype/sort/S15.4.4.11_A2.1_T2.js (previously Failed)
test/built-ins/Array/prototype/sort/S15.4.4.11_A8.js (previously Failed)
test/built-ins/Array/prototype/sort/S15.4.4.11_A3_T2.js [strict mode] (previously Failed)
test/built-ins/Array/prototype/sort/S15.4.4.11_A3_T2.js (previously Failed)
test/built-ins/Array/prototype/sort/prop-desc.js [strict mode] (previously Failed)
test/built-ins/Array/prototype/sort/prop-desc.js (previously Failed)
test/built-ins/Array/prototype/sort/length.js [strict mode] (previously Failed)
test/built-ins/Array/prototype/sort/length.js (previously Failed)
test/built-ins/Array/prototype/sort/S15.4.4.11_A2.2_T3.js [strict mode] (previously Failed)
test/built-ins/Array/prototype/sort/S15.4.4.11_A2.2_T3.js (previously Failed)
test/built-ins/Array/prototype/sort/S15.4.4.11_A2.1_T3.js [strict mode] (previously Failed)
test/built-ins/Array/prototype/sort/S15.4.4.11_A2.1_T3.js (previously Failed)
test/built-ins/Array/prototype/sort/stability-2048-elements.js [strict mode] (previously Failed)
test/built-ins/Array/prototype/sort/stability-2048-elements.js (previously Failed)
test/built-ins/Array/prototype/sort/S15.4.4.11_A4_T3.js [strict mode] (previously Failed)
test/built-ins/Array/prototype/sort/S15.4.4.11_A4_T3.js (previously Failed)
test/built-ins/Array/prototype/sort/S15.4.4.11_A2.2_T2.js [strict mode] (previously Failed)
test/built-ins/Array/prototype/sort/S15.4.4.11_A2.2_T2.js (previously Failed)
test/built-ins/Array/prototype/sort/S15.4.4.11_A1.2_T2.js [strict mode] (previously Failed)
test/built-ins/Array/prototype/sort/S15.4.4.11_A1.2_T2.js (previously Failed)
test/built-ins/Array/prototype/sort/stability-513-elements.js [strict mode] (previously Failed)
test/built-ins/Array/prototype/sort/stability-513-elements.js (previously Failed)
test/built-ins/Array/prototype/sort/S15.4.4.11_A1.4_T2.js [strict mode] (previously Failed)
test/built-ins/Array/prototype/sort/S15.4.4.11_A1.4_T2.js (previously Failed)
test/built-ins/Array/prototype/sort/S15.4.4.11_A2.2_T1.js [strict mode] (previously Failed)
test/built-ins/Array/prototype/sort/S15.4.4.11_A2.2_T1.js (previously Failed)
test/built-ins/Array/prototype/sort/S15.4.4.11_A1.2_T1.js [strict mode] (previously Failed)
test/built-ins/Array/prototype/sort/S15.4.4.11_A1.2_T1.js (previously Failed)
test/built-ins/Array/prototype/sort/call-with-primitive.js [strict mode] (previously Failed)
test/built-ins/Array/prototype/sort/call-with-primitive.js (previously Failed)
test/built-ins/Array/prototype/sort/S15.4.4.11_A1.4_T1.js [strict mode] (previously Failed)
test/built-ins/Array/prototype/sort/S15.4.4.11_A1.4_T1.js (previously Failed)
test/built-ins/Array/prototype/sort/S15.4.4.11_A6_T2.js [strict mode] (previously Failed)
test/built-ins/Array/prototype/sort/S15.4.4.11_A6_T2.js (previously Failed)
test/built-ins/Array/prototype/sort/stability-11-elements.js [strict mode] (previously Failed)
test/built-ins/Array/prototype/sort/stability-11-elements.js (previously Failed)
test/built-ins/Array/prototype/sort/S15.4.4.11_A2.1_T1.js [strict mode] (previously Failed)
test/built-ins/Array/prototype/sort/S15.4.4.11_A2.1_T1.js (previously Failed)
test/built-ins/Array/prototype/sort/bug_596_1.js [strict mode] (previously Failed)
test/built-ins/Array/prototype/sort/bug_596_1.js (previously Failed)
test/built-ins/Array/prototype/sort/name.js [strict mode] (previously Failed)
test/built-ins/Array/prototype/sort/name.js (previously Failed)
test/built-ins/Array/prototype/sort/S15.4.4.11_A1.1_T1.js [strict mode] (previously Failed)
test/built-ins/Array/prototype/sort/S15.4.4.11_A1.1_T1.js (previously Failed)
test/built-ins/Array/prototype/sort/S15.4.4.11_A1.3_T1.js [strict mode] (previously Failed)
test/built-ins/Array/prototype/sort/S15.4.4.11_A1.3_T1.js (previously Failed)
test/language/expressions/property-accessors/S11.2.1_A4_T4.js [strict mode] (previously Failed)
test/language/expressions/property-accessors/S11.2.1_A4_T4.js (previously Failed)
test/language/statements/function/S13.2.1_A5_T1.js [strict mode] (previously Failed)
test/language/statements/function/S13.2.1_A5_T1.js (previously Failed)

@HalidOdat HalidOdat self-requested a review August 20, 2021 10:05
HalidOdat
HalidOdat approved these changes Aug 21, 2021
View reviewed changes
Copy link
Member

@HalidOdat HalidOdat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me :)

@jedel1043
Copy link
Member Author

Looks good to me :)

Nice! Let me rebase to merge it then 😄

@HalidOdat HalidOdat changed the title Implement Array.prototype.sort Implement Array.prototype.sort Aug 22, 2021
@HalidOdat HalidOdat merged commit d286dc6 into boa-dev:master Aug 22, 2021
@jedel1043 jedel1043 deleted the array-sort branch August 22, 2021 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HalidOdat HalidOdat HalidOdat approved these changes

Assignees
No one assigned
Labels
builtins PRs and Issues related to builtins/intrinsics enhancement New feature or request
Projects
None yet
Milestone
v0.13.0
Development

Successfully merging this pull request may close these issues.
3 participants
@jedel1043 @Razican @HalidOdat