Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix cargo check errors #1338

Merged
merged 5 commits into from
Jun 19, 2021
Merged

fix cargo check errors #1338

merged 5 commits into from
Jun 19, 2021

Conversation

neeldug
Copy link
Contributor

@neeldug neeldug commented Jun 17, 2021

This Pull Request fixes/closes #1335.

It changes the following:

  • moves all f64 constants NAN or Infinity to the associated version
  • Parallelizes the Test262 suite

- move constants to associated constants
- format & lint
@Razican Razican added enhancement New feature or request technical debt labels Jun 17, 2021
@Razican Razican added this to the v0.13.0 milestone Jun 17, 2021
@Razican
Copy link
Member

Razican commented Jun 17, 2021

Test262 conformance changes:

Test result master count PR count difference
Total 78,897 78,897 0
Passed 26,941 26,941 0
Ignored 15,628 15,628 0
Failed 36,328 36,328 0
Panics 0 0 0
Conformance 34.15% 34.15% 0.00%

@neeldug
Copy link
Contributor Author

neeldug commented Jun 18, 2021

Broken tests:

test/built-ins/Number/prototype/toExponential/this-is-0-fractiondigits-is-0.js [strict mode] (previously Passed)
test/built-ins/Number/prototype/toExponential/this-is-0-fractiondigits-is-0.js (previously Passed)

For the broken tests, I ran the tests manually and they seemingly passed, unless I'm trying to run the test incorrectly?

@Razican
Copy link
Member

Razican commented Jun 19, 2021

Let's merge it :) I would have preferred the parallelization to go in a different PR, but the change is minimal, so let's bring it.

@Razican Razican merged commit f673cbc into boa-dev:master Jun 19, 2021
@jedel1043 jedel1043 mentioned this pull request Jun 19, 2021
@neeldug neeldug deleted the associated-consts branch June 19, 2021 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request technical debt
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix errors relating to associated constants in cargo check
3 participants