Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(boa): fix stringpad abstract operation #1347

Merged
merged 2 commits into from
Jun 21, 2021

Conversation

neeldug
Copy link
Contributor

@neeldug neeldug commented Jun 19, 2021

This Pull Request fixes/closes #1306.

It changes the following:

  • renames filter to filler in accordance with spec
  • adds empty string check to StringPad function

- renames filter to filler in accordance with spec
- adds empty string
check to StringPad function

Closes boa-dev#1306
@Razican
Copy link
Member

Razican commented Jun 20, 2021

Test262 conformance changes:

Test result master count PR count difference
Total 78,897 78,897 0
Passed 26,940 26,945 +5
Ignored 15,628 15,624 -4
Failed 36,329 36,328 -1
Panics 1 0 -1
Conformance 34.15% 34.15% +0.01%
Fixed tests:
test/built-ins/Map/prototype/keys/returns-iterator.js (previously Panic)
test/built-ins/String/prototype/padStart/fill-string-empty.js [strict mode] (previously Ignored)
test/built-ins/String/prototype/padStart/fill-string-empty.js (previously Ignored)
test/built-ins/String/prototype/padEnd/fill-string-empty.js [strict mode] (previously Ignored)
test/built-ins/String/prototype/padEnd/fill-string-empty.js (previously Ignored)

Copy link
Member

@Razican Razican left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. But note that it only fixes two of the bugs mentioned in the issue. We still have some more to fix, so this won't close the issue.

Edit: nevermind, I just saw the rest of the fixes. If all of them are fixed, we can close the issue :) we just need to take care when merging, and make sure that all have been fixed.

boa/src/builtins/string/mod.rs Outdated Show resolved Hide resolved
@Razican Razican added bug Something isn't working test Issues and PRs related to the tests. labels Jun 20, 2021
@Razican Razican added this to the v0.13.0 milestone Jun 20, 2021
@Razican Razican merged commit b3ff0bf into boa-dev:master Jun 21, 2021
@neeldug neeldug deleted the fix-fill-string-empty branch June 22, 2021 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some Test262 tests run forever
3 participants