Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Style: Respect rustfmft #1356

Merged
merged 1 commit into from
Jun 22, 2021
Merged

Style: Respect rustfmft #1356

merged 1 commit into from
Jun 22, 2021

Conversation

RageKnify
Copy link
Member

I'll just wait for CI and merge this.

@github-actions
Copy link

Test262 conformance changes:

Test result master count PR count difference
Total 78,897 78,897 0
Passed 26,974 26,974 0
Ignored 15,616 15,616 0
Failed 36,307 36,307 0
Panics 0 0 0
Conformance 34.19% 34.19% 0.00%

@github-actions
Copy link

Benchmark for 2a7dc86

Click to view benchmark
Test PR Benchmark Master Benchmark %
Arithmetic operations (Execution) 274.9±0.48ns 313.2±0.14ns -12.23%
Arithmetic operations (Full) 231.8±0.40µs 231.4±0.34µs +0.17%
Array access (Execution) 4.9±0.03µs 5.5±0.02µs -10.91%
Array access (Full) 225.5±4.43µs 260.4±0.91µs -13.40%
Array creation (Execution) 2.0±0.00ms 2.3±0.00ms -13.04%
Array creation (Full) 2.3±0.00ms 2.6±0.00ms -11.54%
Array pop (Execution) 661.1±2.79µs 753.9±2.92µs -12.31%
Array pop (Full) 1045.2±3.22µs 1177.1±1.44µs -11.21%
Boolean Object Access (Execution) 4.1±0.02µs 4.1±0.02µs 0.00%
Boolean Object Access (Full) 251.3±0.93µs 248.5±0.27µs +1.13%
Clean js (Execution) 473.2±2.23µs 535.9±2.66µs -11.70%
Clean js (Full) 823.8±4.23µs 824.1±2.98µs -0.04%
Clean js (Parser) 31.5±0.07µs 35.5±0.03µs -11.27%
Create Realm 317.2±2.83ns 360.0±3.08ns -11.89%
Dynamic Object Property Access (Execution) 3.9±0.02µs 4.4±0.01µs -11.36%
Dynamic Object Property Access (Full) 225.7±11.31µs 252.2±0.34µs -10.51%
Expression (Parser) 6.1±0.00µs 6.0±0.00µs +1.67%
Fibonacci (Execution) 571.1±1.24µs 646.5±1.87µs -11.66%
Fibonacci (Full) 828.1±1.57µs 926.2±0.94µs -10.59%
For loop (Execution) 16.4±0.06µs 18.6±0.07µs -11.83%
For loop (Full) 233.8±0.70µs 265.3±0.52µs -11.87%
For loop (Parser) 17.3±0.03µs 17.3±0.02µs 0.00%
Goal Symbols (Parser) 10.9±0.04µs 12.4±0.03µs -12.10%
Hello World (Parser) 3.3±0.01µs 3.3±0.00µs 0.00%
Long file (Parser) 622.7±8.90ns 709.5±14.99ns -12.23%
Mini js (Execution) 425.6±3.70µs 481.7±3.84µs -11.65%
Mini js (Full) 762.6±5.01µs 759.2±1.79µs +0.45%
Mini js (Parser) 27.4±0.09µs 30.9±0.03µs -11.33%
Number Object Access (Execution) 3.2±0.01µs 3.2±0.02µs 0.00%
Number Object Access (Full) 247.0±0.70µs 216.4±0.52µs +14.14%
Object Creation (Execution) 3.4±0.01µs 3.8±0.01µs -10.53%
Object Creation (Full) 221.0±0.67µs 252.8±0.46µs -12.58%
RegExp (Execution) 8.8±0.02µs 9.9±0.03µs -11.11%
RegExp (Full) 231.1±1.17µs 262.2±0.28µs -11.86%
RegExp Literal (Execution) 8.9±0.02µs 10.0±0.03µs -11.00%
RegExp Literal (Full) 230.1±0.48µs 259.1±0.39µs -11.19%
RegExp Literal Creation (Execution) 8.6±0.08µs 8.6±0.02µs 0.00%
RegExp Literal Creation (Full) 224.7±0.70µs 252.8±0.46µs -11.12%
Static Object Property Access (Execution) 3.5±0.04µs 4.0±0.01µs -12.50%
Static Object Property Access (Full) 222.3±2.43µs 255.9±0.72µs -13.13%
String Object Access (Execution) 6.3±0.02µs 6.3±0.03µs 0.00%
String Object Access (Full) 251.0±0.31µs 254.9±0.46µs -1.53%
String comparison (Execution) 5.0±0.02µs 5.5±0.02µs -9.09%
String comparison (Full) 224.4±0.86µs 255.1±0.27µs -12.03%
String concatenation (Execution) 3.9±0.01µs 4.4±0.02µs -11.36%
String concatenation (Full) 217.4±1.17µs 249.8±0.55µs -12.97%
String copy (Execution) 3.0±0.01µs 3.4±0.01µs -11.76%
String copy (Full) 212.6±0.49µs 242.8±0.41µs -12.44%
Symbols (Execution) 2.6±0.01µs 3.0±0.01µs -13.33%
Symbols (Full) 234.1±0.52µs 233.6±2.60µs +0.21%

@RageKnify RageKnify merged commit 24f94ff into master Jun 22, 2021
@RageKnify RageKnify deleted the style/rust-fmt branch June 22, 2021 13:09
@Razican Razican added the enhancement New feature or request label Aug 24, 2021
@Razican Razican added this to the v0.13.0 milestone Aug 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants